cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carsten Ziegeler <cziege...@apache.org>
Subject Re: GroupBasedProfileManager
Date Thu, 05 Jan 2006 08:51:04 GMT
Ralph Goers wrote:
> After looking at the AuthenticationProfileManager code I decided to 
> review the GroupBasedProfileManager. While I'm happy to see the 
> read/write lock stuff gone it seems that getGlobalBaseDatas and 
> getGlobalDatas could have a race condition if two threads run at the 
> same time.  Both threads could very well create the CopletBaseData or 
> worse getGlobalBaseDatas might clear copletDatas.object right after the 
> other thread has set it in getGlobalDatas.
> 
Argh, you're right - now, the methods are synchronized...but obviously
that doesn't help. I must have written this code directly after some
party I guess. I'll have a look at it today.

Carsten

-- 
Carsten Ziegeler - Open Source Group, S&N AG
http://www.s-und-n.de
http://www.osoco.org/weblogs/rael/

Mime
View raw message