cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Baptiste Quenot (JIRA)" <>
Subject [jira] Commented: (COCOON-1639) [patch] NekoHTMLTransformer
Date Fri, 13 Jan 2006 12:21:22 GMT
    [ ] 

Jean-Baptiste Quenot commented on COCOON-1639:

Thanks for your contribution, looks nice.  However:

1) In  src/blocks/html/samples/sitemap.xmap, I replaced in pipeline HTMLTransformer/parsed.xml
the "html" transformer with "nekohtml", but I cannot manage to make it run, see Cocoon Samples
at /samples/blocks/html/HTMLTransformer/parsed.xml

2) I notice some overlap (in other words copy/paste) between the two transformers.  Can you
try to factorize the common code, especially the configure() and setup() method?

Once completed, please update your patch againts current SVN.

Thanks in advance.

> [patch] NekoHTMLTransformer
> ---------------------------
>          Key: COCOON-1639
>          URL:
>      Project: Cocoon
>         Type: Improvement
>   Components: Blocks: HTML
>     Versions: 2.1.8
>  Environment: Operating System: All
> Platform: All
>     Reporter: Andrew Stevens
>     Assignee: Cocoon Developers Team
>     Priority: Minor
>  Attachments:, cocoon.log, htmlblock.diff,
> The html block contains HTMLGenerator, HTMLTransformer, NekoHTMLGenerator and...
> hey, where's the NekoHTMLTransformer?
> So, just to complete the set, here's one I prepared earlier :-)
> I've also included an (empty) configuration file, and updated
> the neko generator's setup bits to allow for setting parser features as well as
> properties.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

View raw message