Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Received-SPF: neutral (asf.osuosl.org: local policy)
Mime-Version: 1.0 (Apple Message framework v623)
In-Reply-To: <d8f06f3b452306cde37bb8391f4522a0@robinwyles.com>
References: <7ccb763048ad18a226701a45664c2e44@robinwyles.com>
 <439573EE.7090508@apache.org>
 <d8f06f3b452306cde37bb8391f4522a0@robinwyles.com>
Content-Type: multipart/mixed; boundary=Apple-Mail-10-943960719
Message-Id: <4d4850dc4c80b582a9b70eca444e0049@robinwyles.com>
From: Robin Wyles <rob@robinwyles.com>
Subject: Re: AJAX and upload field
Date: Tue, 6 Dec 2005 12:53:03 +0100
To: dev@cocoon.apache.org


--Apple-Mail-10-943960719
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=US-ASCII;
	format=flowed

Forgot the patch...


--Apple-Mail-10-943960719
Content-Transfer-Encoding: 7bit
Content-Type: application/octet-stream;
	x-unix-mode=0644;
	name="cforms-upload.patch"
Content-Disposition: attachment;
	filename=cforms-upload.patch

Index: /Users/robinwyles/Work/COCOON_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/js/cforms.js
===================================================================
--- /Users/robinwyles/Work/COCOON_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/js/cforms.js	(revision 354055)
+++ /Users/robinwyles/Work/COCOON_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/js/cforms.js	(working copy)
@@ -116,8 +116,12 @@
             continue;
         }
         if (input.type == "file") {
-            // Can't send files in Ajax mode. Fall back to full page
-            return null;
+            if (!input.value) {
+                continue;
+            } else {
+				// Can't send files in Ajax mode. Fall back to full page
+                return null;
+            }
         }
         if (input.tagName.toLowerCase() == "select" && input.multiple) {
             var name = encodeURIComponent(input.name);

--Apple-Mail-10-943960719
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=US-ASCII;
	format=flowed


On 6 Dec 2005, at 12:51, Robin Wyles wrote:

> Sylvain,
>
> On 6 Dec 2005, at 12:20, Sylvain Wallez wrote:
>
>> Robin Wyles wrote:
>>> Hi All,
>>>
>>> I noticed that if a form contains a file field then AJAX is 
>>> completely disabled for that form. I've patched my cforms.js so that 
>>> it disables AJAX only if the file field contains a value. Is this 
>>> valid?
>>
>> Yes, definitely.
>
> Shall I put the patch on JIRA? It's very small - I attached it to this 
> mail.
>
>>
>>> On a more general note would it not be possible to check only the 
>>> fields which are to be refreshed on that browser update before 
>>> deciding whether a full page update is needed, or am I 
>>> misunderstanding something?
>>
>> Full page reload only occurs when we exit form.showForm(). Other than 
>> that, only partial updates are sent back to the browser.
>
> I understand, I think, but in my form it doesn't seem to work that way 
> (this is with a file field).
>
> I have something like...
>
> <fd:group id="group1">
> 	<fd:widgets>
> 		<fd:upload id="upload"/>
> 		[...]
> 	</fd:widgets>
> </fd:group>
>
> <fd:booleanfield id="boolean">
> 	<fd:on-value-changed>
> 		<fd:javascript>
> 		  // toggle group2 visibility
> 		</fd:javascript>
> 	</fd:on-value-changed>
> </fd:booleanfield>
>
> <fd:group id="group2">
> 	<fd:widgets>
> 		<fd:field id="field1"/>
> 		[...]
> 		<fd:field id="field10"/>
> 	</fd:widgets>
> </fd:group>
>
> Using the boolean field to toggle group2 works fine with my patch as 
> long as the upload field doesn't have a value. However when it does 
> have a value the whole page is refreshed even though only group1 
> contains the upload field and it is group2 that is the subject of the 
> browser update. Also after toggling the area again after a full page 
> refresh I notice that the value is removed from my file field. Is 
> there something I missed?
>
> Thanks,
>
> Robin

--Apple-Mail-10-943960719--