Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Received-SPF: pass (asf.osuosl.org: domain of joerg.heinicke@gmx.de designates
 213.165.64.21 as permitted sender)
Message-ID: <43B68E06.3090209@gmx.de>
Date: Sat, 31 Dec 2005 14:56:22 +0100
From: Joerg Heinicke <joerg.heinicke@gmx.de>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
 rv:1.7.12) Gecko/20050915
MIME-Version: 1.0
To: dev@cocoon.apache.org
Subject: Re: [RT] Simplifying component handling
References: <43B577E9.6000306@apache.org>
In-Reply-To: <43B577E9.6000306@apache.org>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 8bit

On 30.12.2005 19:09, Carsten Ziegeler wrote:

> class MyComponent implements SOMETHING, ThreadSafe, Disposable,
> Serviceable {
> protected ClassA compA;
> protected ClassB compB;
> protected ServiceManager m;
> 
> public void service(ServiceManager m) {
>   this.m = m;
>   compA = (ClassA)m.lookup(ClassA.ROLE);
>   compB = (ClassB)m.lookup(ClassB.ROLE);
> }
> public void dispose() {
>   if ( m != null ) {
>     m.release(compA);
>     m.release(compB);
>   }
> }
> 
> Way too much code me thinks. So what about:
> 
> class MyComponent implements SOMETHING, ThreadSafe {
>   protected final ClassA compA;
>   protected final ClassB compB;
> 
>   public MyComponent(ClassA a, ClassB b) {
>     compA = a;
>     compB = b;
>   }
> }
> 
> We could simply add constructor injection: if the implementation does
> not provide a default constructor, the available constructor is called
> using reflection and the components are injected on construction of the
> object - no need to configure something in any xml configuration file.
> Implementing this is easy - I did this already years ago for Fortress.

What's the contract for the auto-wiring? Just assuming ClassA and ClassB 
have public static fields called ROLE? Sounds somewhat "strange".

J�rg