cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Upayavira ...@odoko.co.uk>
Subject Re: Patch for i18n bug in forms samples
Date Tue, 08 Nov 2005 09:49:38 GMT
Paul Focke wrote:
> Hi,
> 
> Here is a patch which fixes the i18n in the forms samples.  All it does
> is add 2 lines to src/blocks/forms/samples/sitemap.xmap.
> 
> Judging by the sheer weight of this patch, I'm supposing that a jira
> issue is not necessary.
> 
> 
> 
> ------------------------------------------------------------------------
> 
> Index: src/blocks/forms/samples/sitemap.xmap
> ===================================================================
> --- src/blocks/forms/samples/sitemap.xmap	(revision 331290)
> +++ src/blocks/forms/samples/sitemap.xmap	(working copy)
> @@ -217,7 +217,9 @@
>          | Show a form, using the jx template macros
>          -->
>       <map:match pattern="*-display-pipeline.jx">
> -       <map:generate type="jx" src="forms/{1}_template.xml" label="content1"/>
> +       <map:generate type="jx" src="forms/{1}_template.xml" label="content1">
> +         <map:parameter name="locale" value="{flow-attribute:locale}"/>
> +       </map:generate>
>         <map:transform type="browser-update"/>
>         <map:transform type="i18n">
>           <map:parameter name="locale" value="{flow-attribute:locale}"/>

A ver interesting patch. However, I can't see quite how it would work.
It replaces the 'locale' attribute with, well, 'locale'. Hmm.

Can you explain a bit more what the problem is that it is fixing? And
how does this patch fix it? What am I misunderstanding?

Regards, Upayavira

Mime
View raw message