Return-Path: 
 <dev-return-80461-apmail-cocoon-dev-archive=cocoon.apache.org@cocoon.apache.org>
Delivered-To: apmail-cocoon-dev-archive@www.apache.org
Received: (qmail 59815 invoked from network); 23 Oct 2005 08:53:23 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 23 Oct 2005 08:53:23 -0000
Received: (qmail 83170 invoked by uid 500); 23 Oct 2005 08:53:22 -0000
Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org
Received: (qmail 83142 invoked by uid 500); 23 Oct 2005 08:53:21 -0000
Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@cocoon.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@cocoon.apache.org>
List-Post: <mailto:dev@cocoon.apache.org>
Reply-To: dev@cocoon.apache.org
List-Id: <dev.cocoon.apache.org>
Delivered-To: mailing list dev@cocoon.apache.org
Received: (qmail 83131 invoked by uid 99); 23 Oct 2005 08:53:21 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 23 Oct 2005 01:53:21 -0700
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: neutral (asf.osuosl.org: local policy)
Received: from [84.96.21.10] (HELO mail.anyware-tech.com) (84.96.21.10)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 23 Oct 2005 01:53:19 -0700
Received: from localhost (localhost [127.0.0.1])
	by mail.anyware-tech.com (Postfix) with ESMTP id DE70A338EA
	for <dev@cocoon.apache.org>; Sun, 23 Oct 2005 10:53:01 +0200 (CEST)
Received: from mail.anyware-tech.com ([127.0.0.1])
	by localhost (trinity [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 17172-08 for <dev@cocoon.apache.org>;
	Sun, 23 Oct 2005 10:53:00 +0200 (CEST)
Received: from [192.168.0.100] (lns-vlq-39f-81-56-134-235.adsl.proxad.net
 [81.56.134.235])
	by mail.anyware-tech.com (Postfix) with ESMTP id 68531338E7
	for <dev@cocoon.apache.org>; Sun, 23 Oct 2005 10:53:00 +0200 (CEST)
Message-ID: <435B4F67.5060107@apache.org>
Date: Sun, 23 Oct 2005 10:52:55 +0200
From: Sylvain Wallez <sylvain@apache.org>
User-Agent: Thunderbird 1.4.1 (Macintosh/20051006)
MIME-Version: 1.0
To: dev@cocoon.apache.org
Subject: Re: svn commit: r326930 - in /cocoon/blocks/forms/trunk:
 java/org/apache/cocoon/forms/event/
 java/org/apache/cocoon/forms/formmodel/
 java/org/apache/cocoon/forms/resources/
 samples/forms/
References: <20051020160341.81288.qmail@minotaur.apache.org>
 <435AA277.3070208@reverycodes.com>
In-Reply-To: <435AA277.3070208@reverycodes.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at anyware-tech.com
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

Vadim Gritsenko wrote:
> sylvain@apache.org wrote:
>> Author: sylvain
>> Date: Thu Oct 20 09:03:19 2005
>> New Revision: 326930
>>
>> URL: http://svn.apache.org/viewcvs?rev=326930&view=rev
>> Log:
>> Fields with value-changed listeners are triggering form submit 
>> automatically. <fi:styling submit-on-change="true"> is no more needed"
>
> That's significant change. I don't see an entry in (2.1) status.xml yet

That's right. I wanted to commit things before the code freeze, and will 
update status.xml and docs this week.

> - but please mention that when upgrading from 2.1.7 all templates has 
> to be updated to include submit-on-change="false" to keep'em forms 
> from breaking:
>
>   <ft id="foo">
>     <fi:styling submit-on-change="false">
>   </ft>

Sorry, I don't see the point here. The submit-on-change is automatic for 
those fields that _do have_ change listeners. From my experience, most 
if not all fields with change listeners have a submit-on-change='true', 
meaning nothing will change for the vast majority of forms.

The only case where form behaviour will be different will be for fields 
that have change listeners but no submit-on-change="true" in the 
template. These forms will not be broken, but will roundtrip too much to 
the server.

Sylvain

-- 
Sylvain Wallez                        Anyware Technologies
http://people.apache.org/~sylvain     http://www.anyware-tech.com
Apache Software Foundation Member     Research & Technology Director