cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vadim Gritsenko <va...@reverycodes.com>
Subject Re: SQLTransformer design question
Date Thu, 13 Oct 2005 14:39:08 GMT
dbennett1556@netscape.net wrote:
> Our barrier to be able to extend the SQLTransformer is the Inner Class
> Query is either package access in the 2.1.7 version or now refactored
> to private access in the latest code base.
> 
> Could Query be a interface with a default implementation , a non Inner
> Public Class, a simple Protected Inner Class...? 
> Is there some other way of allowing inheritance?

Yes. Inner class Query can be made protected, additional method  protected Query 
newQuery()  should be added to the SQLTransformer, and all usages of  new 
Query()  should be converted to calls to newQuery().

In this case, in the derived SQLTransformer, you can extend from Query, and 
override newQuery() method to provide your own Query implementation.

If that sounds good to you, you can prepare a patch, put into into Bugzilla, and 
send a note here.

Vadim

Mime
View raw message