cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vadim Gritsenko <va...@reverycodes.com>
Subject Re: FYI New Exception thrown (was Re: svn commit: r292770 - in /cocoon/trunk/src/java/org/apache/cocoon/i18n: XMLResourceBundleFactory.java XMLResourceBundleNotFoundException.java)
Date Wed, 12 Oct 2005 03:42:13 GMT
Sylvain Wallez wrote:
> Berin Loritsch wrote:
> 
>> I changed the "FIXME" comment that had a question with a runtime 
>> exception.  This should answer the question quite well.  Before we 
>> simply ignored XMLBundles with no base URL--now we force the system to 
>> deal with it.  It should also help tighten up some code.
> 
> We did not ignored XMLBundles with no base URL, but on the contrary we 
> allowed them, despite not being sure the case was actually really 
> happening with the I18nTransformer.

With XMLResourceBundleFactory, directory was allowed to be empty, in configure() 
method. So empty base seems like valid scenario.

OTOH, null should not be there and it either should result in NPE or be treated 
as empty base. I chose latter...

Vadim

Mime
View raw message