Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 12434 invoked from network); 1 Sep 2005 14:24:50 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 1 Sep 2005 14:24:50 -0000 Received: (qmail 29951 invoked by uid 500); 1 Sep 2005 14:24:47 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 29886 invoked by uid 500); 1 Sep 2005 14:24:47 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 29873 invoked by uid 99); 1 Sep 2005 14:24:47 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Sep 2005 07:24:47 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [130.237.222.115] (HELO smtp.nada.kth.se) (130.237.222.115) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Sep 2005 07:25:01 -0700 X-Authentication-Info: The sender was authenticated as danielf using PLAIN at smtp.nada.kth.se Received: from [192.168.105.132] ([62.84.203.102]) (authenticated bits=0) by smtp.nada.kth.se (8.12.11/8.12.11) with ESMTP id j81EOh6F010172 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 1 Sep 2005 16:24:43 +0200 (MEST) Message-ID: <43170F60.6020205@nada.kth.se> Date: Thu, 01 Sep 2005 16:25:36 +0200 From: Daniel Fagerstrom User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: en-us, en MIME-Version: 1.0 To: dev@cocoon.apache.org Subject: Re: [2.2] Using includes in the sitemap for components? References: <43155377.90804@apache.org> <43155B56.5040300@apache.org> <4315E6D9.5040802@apache.org> <4316ABD3.2000909@apache.org> <4316B2DB.8090904@nada.kth.se> <4316B435.7090505@apache.org> <4316BEFD.4000600@nada.kth.se> <4316F3A4.9080601@reverycodes.com> <4316FA85.6080406@nada.kth.se> <4316FEBC.3090805@reverycodes.com> In-Reply-To: <4316FEBC.3090805@reverycodes.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Vadim Gritsenko wrote: > Daniel Fagerstrom wrote: ... >> I agree with you that we should skip the sitemap additions and put >> everything in the blocks xconf. > > I suggest the revers: put everything from block's xconf into its xmap :-) > >> Then all blocks both such that has a sitemap and such that only >> exports components would have a root component manager with all >> components from the blocks xconf in it. > > ... from the sitemap.xmap in it :-) > >> For blocks that also have a sitemap the root component manager would >> be pararent component manager for the sitemap. >> >> If sitemap components really need to be part of a sitemap it is a >> question what it would mean to export such a component from a block. >> >> Thoughts? > > At the end, either way will do. We agree about merging components and sitemap components to one configuration file. You suggest that it is included in the block sitemap and that the components of the blocks sitemap is exported so that other blocks can use it. What I'm thinking about is that we will have blocks that export sitemap functionality and components and bloks that just exports blocks or sitemap functionality (but not both). Current blocks have the main task to export components, but they also export sitemap functionality in terns of samples. Now for sitemap and sitemap+component exporting blocks your proposal is fine but for blocks that only export components (which will be a common case when we factor out the sample from the blocks) having a sitemap that only includes components does not make tha much sense to me. What I propose is that the block descriptor block.xml contains both a sitemap path (as it has today) and a component configuration path(s) (a new addition) both optional. Then a block with a component configuration path will create a root component manager where everything from the component configuration is exported. If there also is a sitemap path, the sitemap processor will use the root component manager as parent component manager. If there is a sitemap configuration path but no component configuration path the block will not export any components. I prefer the described solution partly because a sitemap configuration IMO not make sense for component only blocks and partly because it provide a very smooth evolutionary path towards real blocks. The blocks can look like today, only a block.xml with paths to the current component configuration pat, main sitemap etc and a Manifest.mf is needed. /Daniel