Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Message-ID: <4316F85B.2010309@apache.org>
Date: Thu, 01 Sep 2005 14:47:23 +0200
From: Carsten Ziegeler <cziegeler@apache.org>
User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716)
MIME-Version: 1.0
To: dev@cocoon.apache.org
Subject: Re: svn commit: r264119 - in /cocoon/branches/BRANCH_2_1_X:
 src/java/org/apache/cocoon/serialization/AbstractTextSerializer.java
 src/java/org/apache/cocoon/transformation/CIncludeTransformer.java status.xml
References: <20050829120233.16198.qmail@minotaur.apache.org>
 <43135E73.8090607@reverycodes.com> <4314189C.4040502@apache.org>
 <431469C0.5040206@apache.org> <43146DE3.7060701@apache.org>
 <43148192.7030403@apache.org> <4316EDE6.2090104@reverycodes.com>
 <4316F1A4.60802@apache.org> <4316F59E.2030506@reverycodes.com>
In-Reply-To: <4316F59E.2030506@reverycodes.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Vadim Gritsenko wrote:
>>a) what exactly do you want to revert? Both parts?
> 
> 
> Ideally, both. Change to CIncludeTransformer sounds more offending, though.
> 
I still don't get why, really. But actually I don't care and will remove
it from CInclude transformer just to keep you happy.

> 
> 
>>b) where is a working solution that fills the gap then?
> 
> 
> If you add couple of lines to that one, yes:
>    http://issues.apache.org/bugzilla/show_bug.cgi?id=30018
> 
Hmm, wasn't it you who said that it's better to split up the
functionality (separation of concerns). So removing comments is imho a
different concern as cleaning up.

> 
> Out of curiosity, why would you want to keep root comment?
> 
For example to have a copyright statement at the beginning of the document.

Anyways as I'm really tired of these discussions I will just revert the
whole thing.

Carsten

-- 
Carsten Ziegeler - Open Source Group, S&N AG
http://www.s-und-n.de
http://www.osoco.org/weblogs/rael/