cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hepabolu <hepab...@gmail.com>
Subject [CForms] Fixing samples, some questions arise
Date Wed, 07 Sep 2005 12:22:17 GMT
Guys,

I'm currently patching the CForms samples with the patch I entered in 
Bugzilla just before the 2.1.7 release.
(http://issues.apache.org/bugzilla/show_bug.cgi?id=34077)

Some questions arose:

1. the XHR_carselector sample is broken. I think it should either be 
fixed (seems to be difficult) or removed entirely. Since the current 
AJAX implementation is better, I propose to remove it.

2. Small bug: the Datasource chooser defaults to "SQL". Switching to 
"empty" doesn't work, first switching to "file" does work and subsequent 
switch to "empty" works. I have not looked into fixing the bug, but I 
propose to default the chooser to "empty" rather than "SQL". I'll leave 
the "<fd:initial-value>" line in comments for documentation.

3. Just committed two samples (in BRANCH) where I added a header with a 
short description of the sample's purpose. WDYT? If there are no major 
objections, I'll add this kind of headers to all Forms samples.

And I'll update TRUNK as well.

Bye, Helma


Mime
View raw message