cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Antonio Gallardo <agalla...@agssa.net>
Subject Re: svn commit: r278641 - /cocoon/branches/BRANCH_2_1_X/src/blocks/xsp/java/org/apache/cocoon/components/language/markup/xsp/XSPExpressionParser.java
Date Sun, 04 Sep 2005 23:33:07 GMT
pier@apache.org wrote:

>Author: pier
>Date: Sun Sep  4 16:29:09 2005
>New Revision: 278641
>
>URL: http://svn.apache.org/viewcvs?rev=278641&view=rev
>Log:
>Fixing wrong encoding bug
>
>Modified:
>    cocoon/branches/BRANCH_2_1_X/src/blocks/xsp/java/org/apache/cocoon/components/language/markup/xsp/XSPExpressionParser.java
>
>@@ -211,7 +211,7 @@
>                     parser.setState(EXPRESSION_CHAR_STATE);
>                     break;
> 
>-                case '�':
>+                case '\u00B4':
>                     parser.append(ch);
>                     parser.setState(EXPRESSION_SHELL_STATE);
>                     break;
>@@ -235,10 +235,10 @@
>     protected static final State EXPRESSION_CHAR_STATE = new QuotedState('\'');
> 
>     /**
>-     * The parser has encountered '�' in <code>{@link EXPRESSION_STATE}</code>
>-     * to start a Python string constant.
>+     * The parser has encountered '\u00B4' (Unicode Latin-1 Acute Accent) in
>+     * <code>{@link EXPRESSION_STATE}</code> to start a Python string constant.
>      */
>-    protected static final State EXPRESSION_SHELL_STATE = new QuotedState('�');
>+    protected static final State EXPRESSION_SHELL_STATE = new QuotedState('\u00B4');
> 
>  
>
Why not only left the original char as it was before your first change? 
It was working. Having a UTF-8 IMO is not good.

Best Regards,

Antonio Gallardo.


Mime
View raw message