cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vadim Gritsenko <va...@reverycodes.com>
Subject Re: svn commit: r264119 - in /cocoon/branches/BRANCH_2_1_X: src/java/org/apache/cocoon/serialization/AbstractTextSerializer.java src/java/org/apache/cocoon/transformation/CIncludeTransformer.java status.xml
Date Thu, 01 Sep 2005 13:31:18 GMT
Carsten Ziegeler wrote:
> Vadim Gritsenko wrote:
> 
>>>a) what exactly do you want to revert? Both parts?
>>
>>Ideally, both. Change to CIncludeTransformer sounds more offending, though.
> 
> I still don't get why, really.

I don't like it for two reasons:

   * CInclude is not the only way to inject external content
     into the pipeline. Alternatively, you can use:

      - xinclude, include transformers
      - aggregate
      - file, xmldb, blob, etc source
      - sql transformer
      - i18n transformer

     Should all of the above be modified to have same features?

   * It mixes concerns. Task of CInclude is to inject external
     content into the pipeline, not to process it. If you want
     to do some processing, do it as a next step (or previous
     step). Otherwise, we can keep its functionality growing and
     end up with JavascriptXSLTCIncludeTransformer, which in
     addition to inclusion, will filter XML through Javascript
     and process output with XSLT :)


>>>b) where is a working solution that fills the gap then?
>>
>>If you add couple of lines to that one, yes:
>>   http://issues.apache.org/bugzilla/show_bug.cgi?id=30018
> 
> Hmm, wasn't it you who said that it's better to split up the
> functionality (separation of concerns). So removing comments is imho a
> different concern as cleaning up.

I see comment / namespace removal and indenting as a single task - lexical 
normalization of xml :-)

Thanks,
Vadim

Mime
View raw message