cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sylvain Wallez <sylv...@apache.org>
Subject Re: svn commit: r264119 - in /cocoon/branches/BRANCH_2_1_X: src/java/org/apache/cocoon/serialization/AbstractTextSerializer.java src/java/org/apache/cocoon/transformation/CIncludeTransformer.java status.xml
Date Thu, 01 Sep 2005 13:13:53 GMT
Carsten Ziegeler wrote:

>Vadim Gritsenko wrote:
>  
>
>>>a) what exactly do you want to revert? Both parts?
>>>      
>>>
>>Ideally, both. Change to CIncludeTransformer sounds more offending, though.
>>
>>    
>>
>I still don't get why, really. But actually I don't care and will remove
>it from CInclude transformer just to keep you happy.
>  
>

Me too will be happy :-)

>>>b) where is a working solution that fills the gap then?
>>>      
>>>
>>If you add couple of lines to that one, yes:
>>   http://issues.apache.org/bugzilla/show_bug.cgi?id=30018
>>
>>    
>>
>Hmm, wasn't it you who said that it's better to split up the
>functionality (separation of concerns). So removing comments is imho a
>different concern as cleaning up.
>  
>

That was me!

We can consider that the concept of "cleaning" an XML stream can be 
split into several different tasks, which include stripping comments and 
correcting whitespace. We may want these subtasks to be all active by 
default and disable some of them through configuration or parameters though.

Sylvain

-- 
Sylvain Wallez                        Anyware Technologies
http://people.apache.org/~sylvain     http://www.anyware-tech.com
Apache Software Foundation Member     Research & Technology Director


Mime
View raw message