cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carsten Ziegeler <cziege...@apache.org>
Subject Re: svn commit: r264119 - in /cocoon/branches/BRANCH_2_1_X: src/java/org/apache/cocoon/serialization/AbstractTextSerializer.java src/java/org/apache/cocoon/transformation/CIncludeTransformer.java status.xml
Date Thu, 01 Sep 2005 12:47:23 GMT
Vadim Gritsenko wrote:
>>a) what exactly do you want to revert? Both parts?
> 
> 
> Ideally, both. Change to CIncludeTransformer sounds more offending, though.
> 
I still don't get why, really. But actually I don't care and will remove
it from CInclude transformer just to keep you happy.

> 
> 
>>b) where is a working solution that fills the gap then?
> 
> 
> If you add couple of lines to that one, yes:
>    http://issues.apache.org/bugzilla/show_bug.cgi?id=30018
> 
Hmm, wasn't it you who said that it's better to split up the
functionality (separation of concerns). So removing comments is imho a
different concern as cleaning up.

> 
> Out of curiosity, why would you want to keep root comment?
> 
For example to have a copyright statement at the beginning of the document.

Anyways as I'm really tired of these discussions I will just revert the
whole thing.

Carsten

-- 
Carsten Ziegeler - Open Source Group, S&N AG
http://www.s-und-n.de
http://www.osoco.org/weblogs/rael/

Mime
View raw message