Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Received-SPF: pass (asf.osuosl.org: domain of ap-cocoon-dev@m.gmane.org
 designates 80.91.229.2 as permitted sender)
To: dev@cocoon.apache.org
From: BURGHARD =?ISO-8859-15?Q?=C9ric?= <eric.burghard@systheo.com>
Subject: Re: Suggestion for XHTMLSerializer
Date: Fri, 05 Aug 2005 13:49:53 +0200
Lines: 82
Message-ID: <dcvjmk$j9v$1@sea.gmane.org>
References: <b677085305080202252fb491ff@mail.gmail.com>
 <1123067609.7378.9.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 8Bit
User-Agent: KNode/0.9.1
Sender: news <news@sea.gmane.org>

Thorsten Scherler wrote:

> On Tue, 2005-08-02 at 11:25 +0200, Antonio Fiol Bonn�n wrote:
>> Hello,
>> 
>> I am finding a problem with empty elements when serving content with
>> the text/html content type on Firefox.
> 
>> For example, collapsed empty div elements cause havoc in firefox. A
>> possible workaround would be implementing the compatibility guidelines
>> indicated in the W3C recommendations.
>> 
>> In particular, I would add the same check already present for style,
>> script and textarea for any element whose end tag is required in HTML
>> 4.01.
>> 
> 

I found a simple solution to this problem.

In fact the XMLSerializer didn't take the 'method' parameter into account.
At least in saxon8 (never test with other xslt processor, but it should
work too), if you put <xsl:output method="xhtml"/> all tags like div,
script, or inputarea remains unclosed.

I think this is a bug with XMLSerializer which enforce the method to be
'xml'. The folowing simple class let you choose the serialization method.

public class XMLSerializer2 extends AbstractTextSerializer {

    /**
     * Set the configurations for this serializer.
     */
    public void configure(Configuration conf)
    throws ConfigurationException {
        super.configure( conf );
    }

    /**
     * Set the {@link OutputStream} where the requested resource should
     * be serialized.
     */
    public void setOutputStream(OutputStream out) throws IOException {
        super.setOutputStream(out);
        try {
            TransformerHandler handler = this.getTransformerHandler();
            handler.getTransformer().setOutputProperties(this.format);
            handler.setResult(new StreamResult(this.output));
            this.setContentHandler(handler);
            this.setLexicalHandler(handler);
        } catch (Exception e) {
            final String message = "Cannot set XMLSerializer outputstream"; 
            throw new CascadingIOException(message, e);
        }
    }

}

Now just configure this serializer in sitemap.xmap like you do with regular
XMLSerializer.

<map:serializer logger="sitemap.serializer.xhtml" mime-type="text/html"
name="xhtml" pool-grow="2" pool-max="64" pool-min="2"
src="org.apache.cocoon.serialization.XMLSerializer2">
                <doctype-public>-//W3C//DTD XHTML 1.0
Strict//EN</doctype-public>

<doctype-system>http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd</doctype-system>
                <encoding>UTF-8</encoding>
                <!-- for i6 compat mode-->
                <omit-xml-declaration>yes</omit-xml-declaration>
                <method>xhtml</method>
<transformer-factory>net.sf.saxon.TransformerFactoryImpl</transformer-factory>
</map:serializer>

I wrote a much more powerfull solution: the XSLSerializer, which let you
control the serialization through an xsl stylesheet (an so use the
xsl:output tag as well as some template rules to make final cleanup like
namespace deletion or href contextualization). I need to do some cleanup,
and i will submit a patch.

Regards