Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 79708 invoked from network); 29 Aug 2005 19:14:01 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 29 Aug 2005 19:14:01 -0000 Received: (qmail 96787 invoked by uid 500); 29 Aug 2005 19:13:58 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 96762 invoked by uid 500); 29 Aug 2005 19:13:58 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 96743 invoked by uid 99); 29 Aug 2005 19:13:58 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Aug 2005 12:13:58 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [68.230.240.34] (HELO eastrmmtao05.cox.net) (68.230.240.34) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Aug 2005 12:14:13 -0700 Received: from [192.168.0.100] (really [70.179.64.83]) by eastrmmtao05.cox.net (InterMail vM.6.01.04.00 201-2131-118-20041027) with ESMTP id <20050829191354.QUPX15295.eastrmmtao05.cox.net@[192.168.0.100]> for ; Mon, 29 Aug 2005 15:13:54 -0400 Message-ID: <43135E73.8090607@reverycodes.com> Date: Mon, 29 Aug 2005 15:13:55 -0400 From: Vadim Gritsenko User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: dev@cocoon.apache.org Subject: Re: svn commit: r264119 - in /cocoon/branches/BRANCH_2_1_X: src/java/org/apache/cocoon/serialization/AbstractTextSerializer.java src/java/org/apache/cocoon/transformation/CIncludeTransformer.java status.xml References: <20050829120233.16198.qmail@minotaur.apache.org> In-Reply-To: <20050829120233.16198.qmail@minotaur.apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N cziegeler@apache.org wrote: > Add possibility to remove comments to all text based serializers and to cinclude transformer. Do you really think serializers and cinclude transformer are a good place for additional xml filtering logic? What if you want to indent included xml - is it good idea to add this code into serializers & include transformer too? Or if you want to drop all the whitespaces. Etc ad infinitum. I'd think that separate filtering / cleaning transformer is a much cleaner approach. WDYT? Vadim