cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sylvain Wallez <sylv...@apache.org>
Subject Re: svn commit: r264119 - in /cocoon/branches/BRANCH_2_1_X: src/java/org/apache/cocoon/serialization/AbstractTextSerializer.java src/java/org/apache/cocoon/transformation/CIncludeTransformer.java status.xml
Date Tue, 30 Aug 2005 07:52:38 GMT
Vadim Gritsenko wrote:

> cziegeler@apache.org wrote:
>
>> Add possibility to remove comments to all text based serializers and 
>> to cinclude transformer.
>
>
> Do you really think serializers and cinclude transformer are a good 
> place for additional xml filtering logic? What if you want to indent 
> included xml - is it good idea to add this code into serializers & 
> include transformer too? Or if you want to drop all the whitespaces. 
> Etc ad infinitum.
>
> I'd think that separate filtering / cleaning transformer is a much 
> cleaner approach. WDYT?


+1. Otherwise, we'll end up duplicating the cleaning code (or the use of 
a common class) all over the place.

Sylvain

-- 
Sylvain Wallez                        Anyware Technologies
http://people.apache.org/~sylvain     http://www.anyware-tech.com
Apache Software Foundation Member     Research & Technology Director


Mime
View raw message