cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 35162] - [PATCH] EclipseJavaCompiler chokes on warnings
Date Wed, 31 Aug 2005 07:38:35 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=35162>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35162





------- Additional Comments From werbung@kuhnle.net  2005-08-31 09:38 -------
I think we shouldn't suppress individual warnings, because then, everytime the
Eclipse people add a new one, we have to change our code, too, to turn it off.

The patch replaces getProblems with getErrors, which in turn calls getProblems,
so at least it won't make things worse. Hopefully :) 

With CompilationResult, I don't get the design rationale. Field "problems" is
public, so are we supposed to access it directly? Can we assume the field is
initialized by the compiler when we get the result? I'll look into it, but in
the meantime I suggest applying the patch, since it doesn't change the status
quo regarding getProblems-calls.




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Mime
View raw message