Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 19827 invoked from network); 10 Jul 2005 22:15:47 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 10 Jul 2005 22:15:47 -0000 Received: (qmail 45051 invoked by uid 500); 10 Jul 2005 22:15:44 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 44995 invoked by uid 500); 10 Jul 2005 22:15:44 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 44982 invoked by uid 99); 10 Jul 2005 22:15:44 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 Jul 2005 15:15:44 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of joerg.heinicke@gmx.de designates 213.165.64.20 as permitted sender) Received: from [213.165.64.20] (HELO mail.gmx.net) (213.165.64.20) by apache.org (qpsmtpd/0.29) with SMTP; Sun, 10 Jul 2005 15:15:41 -0700 Received: (qmail invoked by alias); 10 Jul 2005 22:15:40 -0000 Received: from p549D0D8C.dip0.t-ipconnect.de (EHLO [192.168.122.254]) [84.157.13.140] by mail.gmx.net (mp002) with SMTP; 11 Jul 2005 00:15:40 +0200 X-Authenticated: #3483660 Message-ID: <42D19E1B.2090300@gmx.de> Date: Mon, 11 Jul 2005 00:15:55 +0200 From: Joerg Heinicke User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.8) Gecko/20050511 X-Accept-Language: de-de, de, en-us, en-gb, en MIME-Version: 1.0 To: dev@cocoon.apache.org Subject: Re: [CForms] ValidationError, Was: Add isValid() to a widget? References: <42CD1680.4080300@apache.org> <42CD39F0.6030607@apache.org> <42CD42AF.5040709@apache.org> <42CD4700.6070506@apache.org> <42CD4AFD.40901@apache.org> <42CEA48B.7020801@apache.org> <42CECCDF.3080809@reverycodes.com> In-Reply-To: <42CECCDF.3080809@reverycodes.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On 08.07.2005 20:58, Vadim Gritsenko wrote: > While on the subject of forms validation... I noticed several very > annoying things: > > * Field.getValidationError() *does not* simply return validation error: > it has side effects!!! It calls getValue() which can invoke parsing > and validation - depending on state, resulting in weird behavior. > > * Field.setValidationError() *does not* simply set validation error: > it *also* has side effects!!! For some reason it changes widget state, > which can results in weird behavior. > > Any objections on fixing these violations as well? +1 Of course no objections for fixing side effects. Joerg