Vadim Gritsenko wrote:
>
> While on the subject of forms validation... I noticed several very annoying things:
>
> * Field.getValidationError() *does not* simply return validation error:
> it has side effects!!! It calls getValue() which can invoke parsing
> and validation - depending on state, resulting in weird behavior.
>
> * Field.setValidationError() *does not* simply set validation error:
> it *also* has side effects!!! For some reason it changes widget state,
> which can results in weird behavior.
>
> Any objections on fixing these violations as well?
>
Side effects are always bad! +1 from me to fix this.
Carsten
--
Carsten Ziegeler - Open Source Group, S&N AG
http://www.s-und-n.de
http://www.osoco.org/weblogs/rael/
|