Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Received-SPF: neutral (hermes.apache.org: local policy)
Message-ID: <42B074A9.6090402@apache.org>
Date: Wed, 15 Jun 2005 20:34:17 +0200
From: Reinhard Poetz <reinhard@apache.org>
User-Agent: Mozilla Thunderbird 0.9 (Windows/20041103)
MIME-Version: 1.0
To: dev@cocoon.apache.org
Subject: Re: CForms: some renamings on the Widget interface
References: <42ADA010.3050701@apache.org>
In-Reply-To: <42ADA010.3050701@apache.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

Sylvain Wallez wrote:
> Hi all,
> 
> As part of the stabilization work on CForms, there are a couple of 
> changes I'd like to do on the naming-related methods of the Widget 
> interface.
> 
> Today we have:
> - getId() which returns the local name of widget.
> - getRequestParameterName() which returns the combination of the parent 
> widgdet's requestParameterName with the local name.
> 
> Working with advanced templates and Ajax stuff, I find these names 
> increasingly annoying and confusing:
> - each widget produces an HTML element with an "id" attribute filled 
> with getRequestParameterName(), and not getId()!
> - this getRequestParameterName is really tooooo long to type, especially 
> in templates where we have no IDE autocompletion.
> 
> Ideally, I'd like to do the following renaming:
> - getId() --> getName()
> - getRequestParameterName() --> getId()
> But since the meaning of getId() changes, this is likely to cause weird 
> things in existing code.
> 
> So I propose the following:
> - getId() --> getName()
> - getRequestParameterName() --> getFullId()
> - deprecate and remove later getId() and getRequestParameterName().
> 
> Once getId() will have been removed for some time, we'll be able to 
> reintroduce it as an equivalent to getFullId().

+1

In order to be consistent (and as already proposed from somebody else we change 
from <fd:widget id="foo"/> to <fd:widget name="foo"/>, right?

-- 
Reinhard P�tz           Independent Consultant, Trainer & (IT)-Coach 

{Software Engineering, Open Source, Web Applications, Apache Cocoon}

                                        web(log): http://www.poetz.cc
--------------------------------------------------------------------