Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Received-SPF: neutral (hermes.apache.org: local policy)
Message-ID: <42A5962F.4010202@reverycodes.com>
Date: Tue, 07 Jun 2005 08:42:23 -0400
From: Vadim Gritsenko <vadim@reverycodes.com>
User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317)
MIME-Version: 1.0
To: dev@cocoon.apache.org
Subject: Re: Why does XSPMarkupLanguage wrap text in xsp:text?
References: 
 <OF9FFB620A.5BA1D379-ONC1257018.006B8730-C1257018.006BF2EA@kuhnle.net>
In-Reply-To: 
 <OF9FFB620A.5BA1D379-ONC1257018.006B8730-C1257018.006BF2EA@kuhnle.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Jochen Kuhnle wrote:
> Vadim Gritsenko <vadim@reverycodes.com> wrote on 06.06.2005 16:19:44:
> 
>>Jochen Kuhnle wrote:
>>
>>>I noticed that XSPMarkupLanguage.characters wraps text in 
>>>xsp:text elements. Is there a reason for this? At least my XSPs work 
>>>without this...
>>
>>This logic has been there since beginnings of Cocoon2 XSP implementation 
>>[1] 
>>(line 134), and I'd suggest leaving it there as logicsheets might 
>>be dependent on this.
>>
>>I guess original idea was that text() nodes can be safely ignored, while 
>>xsp:text nodes are meaningful. It might be still true, haven't 
>>digged deeper...
> 
> 
> Hmm, I don't think this behaviour is very intuitive, especially if 
> compared to XSLT's handling of <xsl:text>. Maybe we could make it 
> configurable and deprecate it? Especially if doing so does not break 
> anything?

I don't think that it is something which should be configurable: it should be 
either left in (and clarified where necessary) or removed. Without review, I 
can't +1 removal - first need to check that all corner cases are still processed 
properly without <xsp:text/>.

Vadim