cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vadim Gritsenko <va...@reverycodes.com>
Subject Re: svn commit: r191020 - /cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/i18n/XMLResourceBundleFactory.java /cocoon/branches/BRANCH_2_1_X/status.xml
Date Mon, 27 Jun 2005 13:59:26 GMT
Joerg Heinicke wrote:
> On 17.06.2005 00:37, vgritsenko@apache.org wrote:
> 
>> Author: vgritsenko
>> Date: Thu Jun 16 15:37:31 2005
>> New Revision: 191020
>>
>> URL: http://svn.apache.org/viewcvs?rev=191020&view=rev
>> Log:
>> Regression: cacheKey != fileName
> 
> 
> It took some time until I found the regression I introduced. But I 
> wonder why the update method in XMLResourceBundle has a sourceURL 
> parameter at all. It makes no sense to change the source URL of a bundle 
> when reloading it, does it?

No, it does not.


> Wouldn't it be better to save the sourceURL 
> as field of the XMLResourceBundle and remove the parameter from the 
> update method?

You can even remove unused XMLResourceBundle.name and introduce 
XMLResourceBundle.sourceURI instead of it, +1 from me.

Vadim

Mime
View raw message