Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 45463 invoked from network); 31 May 2005 03:00:48 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 31 May 2005 03:00:48 -0000 Received: (qmail 59175 invoked by uid 500); 31 May 2005 03:00:45 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 59111 invoked by uid 500); 31 May 2005 03:00:44 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 59097 invoked by uid 99); 31 May 2005 03:00:44 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (hermes.apache.org: local policy) Received: from lakermmtao09.cox.net (HELO lakermmtao09.cox.net) (68.230.240.30) by apache.org (qpsmtpd/0.28) with ESMTP; Mon, 30 May 2005 20:00:42 -0700 Received: from [192.168.0.103] (really [70.179.64.83]) by lakermmtao09.cox.net (InterMail vM.6.01.04.00 201-2131-118-20041027) with ESMTP id <20050531030037.LNJY6804.lakermmtao09.cox.net@[192.168.0.103]> for ; Mon, 30 May 2005 23:00:37 -0400 Message-ID: <429BD354.9060406@reverycodes.com> Date: Mon, 30 May 2005 23:00:36 -0400 From: Vadim Gritsenko User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: dev@cocoon.apache.org Subject: Re: XSP: EclipseJavaCompiler chokes on warings References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Jochen Kuhnle wrote: > Hi, > > the EclipseJavaCompiler chokes on warnings, resulting in the XSP not > working. This is because in line 365 (cocoon-2.1.8-dev), it checks against > "result.hasProblems()" instead of "result.hasErrors()". I'd like to > propose an option so the compiler ignores warnings and fails only if there > are errors. However, there is more than one way to do this, so 'd like to > ask before I create a patch: > > 1. Add a property "setIgnoreWarnings" to LanguageCompiler, configure the > property in the "programming-language" section of cocoon.xconf and have > CompiledProgrammingLanguage set it. > > 2. Avalonize the Compiler itself and make it configurable. > > 3. Other suggestions? Why not dump warnings into the log file (as WARNings), and stop only on errors - will this be possible? Vadim