Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Received-SPF: pass (hermes.apache.org: local policy)
Message-ID: <428B3263.4080003@mobilebox.pl>
Date: Wed, 18 May 2005 14:17:39 +0200
From: Leszek Gawron <lgawron@mobilebox.pl>
User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206)
MIME-Version: 1.0
To: dev@cocoon.apache.org
Subject: Re: svn commit: r170733 -
 /cocoon/blocks/unsupported/template/trunk/java/org/apache/cocoon/template/instruction/Set.java
References: <20050518113013.34642.qmail@minotaur.apache.org>
 <428B2B9E.5010409@apache.org>
In-Reply-To: <428B2B9E.5010409@apache.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Reinhard Poetz wrote:
> Daniel or Leszek, could you review this please. (I have tried to run the 
> Unit test suite but was overwhelmed by the output) Thanks!
The fix looks correct.

I found out now that jx:set is "hacking ready". Instead of doing
<jx:set name="cformsDummy" value="generateSaxContent()"/>

you can do:
<jx:set value="generateSaxContent()"/>
and the instruction won't even try to register the result in expression 
context:


if (this.var != null) {
     var = this.var.getStringValue(expressionContext);
}
[...]
if (var != null) {
     expressionContext.put(var, value);
}

No more "cformsDummy" in jx:macros. This should also speed things up a 
little bit. Care to check it?

-- 
Leszek Gawron                                      lgawron@mobilebox.pl
IT Manager                                         MobileBox sp. z o.o.
+48 (61) 855 06 67                              http://www.mobilebox.pl
mobile: +48 (501) 720 812                       fax: +48 (61) 853 29 65