Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 42144 invoked from network); 18 May 2005 08:38:58 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 18 May 2005 08:38:58 -0000 Received: (qmail 80399 invoked by uid 500); 18 May 2005 08:34:04 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 80354 invoked by uid 500); 18 May 2005 08:34:03 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 80265 invoked by uid 99); 18 May 2005 08:34:01 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Received: from essemtepe.nada.kth.se (HELO smtp.nada.kth.se) (130.237.222.115) by apache.org (qpsmtpd/0.28) with ESMTP; Wed, 18 May 2005 01:34:00 -0700 X-Authentication-Info: The sender was authenticated as danielf using PLAIN at smtp.nada.kth.se Received: from [192.168.105.31] ([192.58.197.189]) (authenticated bits=0) by smtp.nada.kth.se (8.12.11/8.12.11) with ESMTP id j4I8XhKE029943 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 18 May 2005 10:33:44 +0200 (MEST) Message-ID: <428AFDE2.8040109@nada.kth.se> Date: Wed, 18 May 2005 10:33:38 +0200 From: Daniel Fagerstrom User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: en-us, en MIME-Version: 1.0 To: dev@cocoon.apache.org Subject: Re: Speed of jx-macros compared to FormsTransformer References: <42846E37.6050009@apache.org> <428475EE.80600@apache.org> <4284A5F8.70005@reverycodes.com> <4284AA82.3070508@apache.org> <4288A52E.9000705@apache.org> <4288D7DF.8020001@nada.kth.se> <4289AB65.2000408@apache.org> <428AF523.2020709@mobilebox.pl> <428AF9F6.9000107@apache.org> In-Reply-To: <428AF9F6.9000107@apache.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Sylvain Wallez wrote: > Leszek Gawron wrote: > >> Reinhard Poetz wrote: > >>> >>> AFAICS there is a lot of time spent in the macro execution methods >>> and especially in >>> org.apache.cocoon.template.jxtg.script.Invoker.toDOMNodeList() >> >> >> AAAAha!. That is a really important information. >> Invoker.toDOMNodeList is used by jx:set. This instruction is used >> mainly in jx-macros.xml like this: >> >> > > cformsDummy counts for 10 of the 25 in jx-macros.xml. So > having a would cut down a fair number of them. As described in an earlier mail, there is (probably) a bug in the jx:set implementation that make it call Invoker.toDOMNodeList when it shouldn't. I'm against having a special instruction for performing side effects, as side effects in templates is an anti pattern IMO. As long as we have powerfull ELs we can't forbid it, but at least I think it is good that it creates uggly looking code ;) And as we allready have discussed, most of the uses of side effects in jx-macros would go away with the use of XMLizable in widgets. /Daniel