cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nathaniel Alfred" <Alfred.Nathan...@swx.com>
Subject RE: Re: [IMP] synchronization on session object in Cocoon
Date Thu, 12 May 2005 13:02:47 GMT
>-----Original Message-----
>From: news [mailto:news@sea.gmane.org]On Behalf Of Joerg Heinicke
>Sent: Donnerstag, 12. Mai 2005 11:16
>To: dev@cocoon.apache.org
>Subject: Re: [IMP] synchronization on session object in Cocoon

>I have an implementation with map in HttpRequest and without 
>"double-checked
>locking idiom". Shall I commit it?
>
>Joerg

I think there is a memory leak in http://svn.apache.org/viewcvs?rev=169806&view=rev.
There is a strong reference session.wrappedSession from value to key in

                    // create new wrapper
                    session = new HttpSession(serverSession);
                    sessions.put(serverSession, session);

which causes the WeakHashMap to keep the entries forever.

See the Implementation Note in http://java.sun.com/j2se/1.4.2/docs/api/java/util/WeakHashMap.html.

Cheers, Alfred.
 
 
This message is for the named person's use only. It may contain confidential, proprietary
or legally privileged information. No confidentiality or privilege is waived or lost by any
mistransmission. If you receive this message in error, please notify the sender urgently and
then immediately delete the message and any copies of it from your system. Please also immediately
destroy any hardcopies of the message. You must not, directly or indirectly, use, disclose,
distribute, print, or copy any part of this message if you are not the intended recipient.
The sender's company reserves the right to monitor all e-mail communications through their
networks. Any views expressed in this message are those of the individual sender, except where
the message states otherwise and the sender is authorised to state them to be the views of
the sender's company.

Mime
View raw message