Leszek Gawron wrote:
> Leszek Gawron wrote:
>
>> Sylvain Wallez wrote:
>>
>>> Leszek Gawron wrote:
>>>
>>>> Leszek Gawron wrote:
>>>>
>>>>> Sylvain Wallez wrote:
>>>>>
>>>>>> Hi all,
>>>>>>
>>>>>> The new JXTG based on the template block breaks the form samples
>>>>>> that used it, going into what seem an infinite loop.
>>>>>>
>>>>>> Don't have much time now to dig myself into the code, and
>>>>>> reinstalled locally the old version, but can one of the knowledged
>>>>>> people have a look at it?
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> no problem
>>>>>
>>>> What I meant was I'd have look at that and not that there is no
>>>> problem :)
>>>
>>>
>>>
>>>
>>>
>>> LOL! Yes, that's what I understood :-)
>>
>>
>> I have provided an immediate fix to make the examples work. The
>> problem was that jx:forEach begin="sth" end="sth" took "step" variable
>> of value 0 by default.
>
> I am really good .. apart from providing an ugly fix I broke a test
> case :)
ok ... looks like fixed now .. [1]
In old JXTG this statement
this.step = JXTExpression.compileInt(attrs.getValue("step"), name, locator);
resolved to null if attrs.getValue("step") was null
new JXTG returned an object which caused the problem when evaluating
optional expressions to int - the fact that that attribute was in fact
missing was being lost.
As most of the code was ported unchanged (which means it was already
aware that some JXTExpressions may be null) I reverted the old behaviour
(had to make some things public to do that though).
[1] http://svn.apache.org/viewcvs?rev=168667&view=rev
--
Leszek Gawron lgawron@mobilebox.pl
IT Manager MobileBox sp. z o.o.
+48 (61) 855 06 67 http://www.mobilebox.pl
mobile: +48 (501) 720 812 fax: +48 (61) 853 29 65
|