Return-Path: 
 <dev-return-73259-apmail-cocoon-dev-archive=cocoon.apache.org@cocoon.apache.org>
Delivered-To: apmail-cocoon-dev-archive@www.apache.org
Received: (qmail 39922 invoked from network); 13 Apr 2005 13:01:51 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 13 Apr 2005 13:01:51 -0000
Received: (qmail 17984 invoked by uid 500); 13 Apr 2005 13:01:20 -0000
Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org
Received: (qmail 17947 invoked by uid 500); 13 Apr 2005 13:01:19 -0000
Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@cocoon.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@cocoon.apache.org>
List-Post: <mailto:dev@cocoon.apache.org>
Reply-To: dev@cocoon.apache.org
Delivered-To: mailing list dev@cocoon.apache.org
Received: (qmail 17932 invoked by uid 99); 13 Apr 2005 13:01:19 -0000
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: pass (hermes.apache.org: local policy)
Received: from v07274.home.net.pl (HELO v07274.home.net.pl) (212.85.125.162)
  by apache.org (qpsmtpd/0.28) with SMTP; Wed, 13 Apr 2005 06:01:17 -0700
Received: from sj162.internetdsl.tpnet.pl (HELO ?192.168.1.62?)
 (lgawron.mobilebox@home@80.55.87.162)
  by matrix15.home.net.pl with SMTP; 13 Apr 2005 13:01:10 -0000
Message-ID: <425D1819.5050102@mobilebox.pl>
Date: Wed, 13 Apr 2005 15:01:13 +0200
From: Leszek Gawron <lgawron@mobilebox.pl>
User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: dev@cocoon.apache.org
Subject: Re: svn commit: r161175 -
 cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/util/log/CocoonLogFormatter.java
References: <20050413120728.16292.qmail@minotaur.apache.org>
 <425D13E1.4070609@reverycodes.com> <425D147E.8020607@apache.org>
 <425D179F.7050308@reverycodes.com>
In-Reply-To: <425D179F.7050308@reverycodes.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

Vadim Gritsenko wrote:
> Leszek Gawron wrote:
> 
>> Vadim Gritsenko wrote:
>>
>>> lgawron@apache.org wrote:
>>>
>>>>
>>>> Extend CocoonLogFormatter with the ability to log request query 
>>>> string prepended with '?' character.
>>>
>>>
>>>
>>> Nice! I don't get one thing though: why you are adding '?' in the 
>>> code when you can easily have it in the format string?
>>>
>>> <format type="cocoon">%5.5{priority} %{time} [%{category}] 
>>> (%{uri}?%{query}) %{class:short}: %{message}\n</format>
>>
>>
>> because if you do that:
>>
>> DEBUG   (2005-04-13) 13:07.01:812 [] (Unknown-URI?)
>>                                       ^^^^^^^^^^^^
>>  Unknown-Thread/LoggerSwitch.SwitchingLogger: added logger for category
>>
>> looks a little bit funny :). It's a stupid hack I know.
> 
> 
> Ok :-)
Can I make that default configuration? If so we should warn users that
the logged info may contain confidential data.

-- 
Leszek Gawron                                      lgawron@mobilebox.pl
IT Manager                                         MobileBox sp. z o.o.
+48 (61) 855 06 67                              http://www.mobilebox.pl
mobile: +48 (501) 720 812                       fax: +48 (61) 853 29 65