cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vadim Gritsenko <va...@reverycodes.com>
Subject Re: svn commit: r156697 - in cocoon/branches/BRANCH_2_1_X/src:java/org/apache/cocoon/components/sto re/impl/StoreJanitorImpl.javawebapp/WEB-INF/cocoon.xconf
Date Wed, 09 Mar 2005 22:43:37 GMT
Antonio Gallardo wrote:
> On Mie, 9 de Marzo de 2005, 16:20, vgritsenko@apache.org dijo:
> 
>>         this.minFreeMemory = params.getParameterAsInteger("freememory",
>>1024 * 1024);
>>-        this.maxHeapSize = params.getParameterAsInteger("heapsize", 60 *
>>1024 * 1024);
>>+        this.maxHeapSize = params.getParameterAsInteger("heapsize",
>>66600000);
> 
> 
> 1-Why this change?
> 2-Why only here and not in "this.minFreeMemory"?

Hardcoded default was exactly 60Mb, while Sun JVM by default has a bit less than 
64Mb. Because this setting should be as close to the actual number as possible, 
I propagated default setting from the cocoon.xconf (66600000) back into the code.


> This are only questions. I just want to learn. ;-)

No problem.

Vadim

Mime
View raw message