Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 20609 invoked from network); 24 Feb 2005 15:58:31 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 24 Feb 2005 15:58:31 -0000 Received: (qmail 59002 invoked by uid 500); 24 Feb 2005 15:58:26 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 58944 invoked by uid 500); 24 Feb 2005 15:58:25 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 58916 invoked by uid 99); 24 Feb 2005 15:58:25 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Received: from essemtepe.nada.kth.se (HELO smtp.nada.kth.se) (130.237.222.115) by apache.org (qpsmtpd/0.28) with ESMTP; Thu, 24 Feb 2005 07:58:24 -0800 X-Authentication-Info: The sender was authenticated as danielf using PLAIN at smtp.nada.kth.se Received: from [192.168.105.31] (localhost [127.0.0.1]) (authenticated bits=0) by smtp.nada.kth.se (8.12.10/8.12.11) with ESMTP id j1OFwDon010754 for ; Thu, 24 Feb 2005 16:58:14 +0100 (MET) Message-ID: <421DF996.6020406@nada.kth.se> Date: Thu, 24 Feb 2005 16:58:14 +0100 From: Daniel Fagerstrom User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: en-us, en MIME-Version: 1.0 To: dev@cocoon.apache.org Subject: Re: svn commit: r155189 - in cocoon/trunk/src/blocks/template/java/org/apache/cocoon/template/jxtg: instruction/StartDefine.java script/Parser.java script/event/StartInstruction.java References: <20050224145615.73330.qmail@minotaur.apache.org> <421DEDC3.7020408@apache.org> In-Reply-To: <421DEDC3.7020408@apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Leszek Gawron wrote: > lgawron@apache.org wrote: > >> Author: lgawron >> Date: Thu Feb 24 06:56:13 2005 >> New Revision: 155189 >> >> URL: http://svn.apache.org/viewcvs?view=rev&rev=155189 >> Log: >> every instruction is being notified of end of parsing. No more Parser >> dependency on StartDefine. We can introduce configurable tag set now. > > I cannot find the relevant thread: do we want our instructions' > configuration to reside in sitemap or be set up in cocoon.xconf? Neither ;) Vadim suggested somewhere that we should do it as in the treeprocessor, i.e. there is a configuration file o.a.c.components.treeprocessor.sitemap-language.xml that is included with the resource protocol in o.a.c.components.treeprocessor.DefautlTreeBuilder and o.a.c.components.treeprocessor.TreeProcessor. IIRC Stefano and I and maybe some others found that a good idea. It makes it easy enough to modify things while it at the same time indicates that JXTG has a predefined set of instructions. Furthermore I don't think we should consider the internal interfaces in Template stable until we have implemented at least one more language (the attribute template language) in it. Before that it can contain to much constructions that ties it to ideosyncrasis in JXTG whithout us knowing it. /Daniel