Return-Path: 
 <dev-return-70969-apmail-cocoon-dev-archive=cocoon.apache.org@cocoon.apache.org>
Delivered-To: apmail-cocoon-dev-archive@www.apache.org
Received: (qmail 65799 invoked from network); 1 Feb 2005 16:56:32 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur-2.apache.org with SMTP; 1 Feb 2005 16:56:31 -0000
Received: (qmail 22372 invoked by uid 500); 1 Feb 2005 16:56:27 -0000
Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org
Received: (qmail 22328 invoked by uid 500); 1 Feb 2005 16:56:26 -0000
Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@cocoon.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@cocoon.apache.org>
list-post: <mailto:dev@cocoon.apache.org>
Reply-To: dev@cocoon.apache.org
Delivered-To: mailing list dev@cocoon.apache.org
Received: (qmail 22301 invoked by uid 99); 1 Feb 2005 16:56:26 -0000
X-ASF-Spam-Status: No, hits=-10.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from minotaur.apache.org (HELO minotaur.apache.org)
 (209.237.227.194)
  by apache.org (qpsmtpd/0.28) with SMTP; Tue, 01 Feb 2005 08:56:26 -0800
Received: (qmail 65662 invoked from network); 1 Feb 2005 16:56:22 -0000
Received: from localhost.hyperreal.org (HELO ?127.0.0.1?) (127.0.0.1)
  by localhost.hyperreal.org with SMTP; 1 Feb 2005 16:56:22 -0000
Message-ID: <41FFB53D.3000905@apache.org>
Date: Tue, 01 Feb 2005 17:58:37 +0100
From: Carsten Ziegeler <cziegeler@apache.org>
User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: dev@cocoon.apache.org
Subject: Re: svn commit: r149408 - in cocoon/branches/BRANCH_2_1_X/src:
 deprecated/java/org/apache/cocoon/components/source/
 java/org/apache/cocoon/components/
 java/org/apache/cocoon/components/source/impl/
 java/org/apache/cocoon/components/treeprocessor/
 java/org/apache/cocoon/environment/
 java/org/apache/cocoon/environment/wrapper/ webapp/samples/test/pass-through/
References: <20050201154345.19608.qmail@minotaur.apache.org>
In-Reply-To: <20050201154345.19608.qmail@minotaur.apache.org>
X-Enigmail-Version: 0.89.5.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Rating: localhost.hyperreal.org 1.6.2 0/1000/N
X-Virus-Checked: Checked
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N

sylvain@apache.org wrote:
> Author: sylvain
> Date: Tue Feb  1 07:43:40 2005
> New Revision: 149408
> 
>      /**
> -     * Remove attribute from the current instance, as well as from the
> -     * wrapped environment.
> +     * Remove attribute from the current instance.
>       *
>       * @param name a <code>String</code> value
>       */
>      public void removeAttribute(String name) {
>          super.removeAttribute(name);
> -        this.environment.removeAttribute(name);
>      }
>  
Hmm, isn't this an incompatible change? Ok, I always thought that the 
implementation was not the way one would expect, but we shouldn't imho 
introduce such changes during maintenance releases. I'm fine with 
changing this for 2.2.


Carsten