cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sylvain Wallez <sylv...@apache.org>
Subject Re: CONTRIBUTION: repeater-widget (insert row): InsertRowsActionDefinition
Date Thu, 24 Feb 2005 17:06:59 GMT
depub2 wrote:

>Well, what do you guys think? Does 7 days of silence amount to agreement??
>I'll be happy to make any mods you suggest and resubmit source to you for
>inclusion..
>  
>

Added. When including your patch, I had a quick look at Excel and found 
that the row insertion command adds rows _before_ the selected rows as 
you initially suggested. So I added it that way. I made a small change 
though by clearing the selection after executing the action.

If you'd like your name to be included for fame and posterity in 
Cocoon's release notes, please give us your full name as "David" is a 
bit unprecise.

>#define SUBJECT_DRIFT_ON
>Also, I have a "2 line" minor tweak to the forms-calendar-styling.xsl that
>disables the "calendar icon/popup" when a datetype="date" widget is set to
>readonly, disabled, or hidden (in these cases, we don't want an icon or
>popup - ESPECIALLY when the widget is supposed to be "hidden").
>
>The change was simple, in
>cocoon/samples/blocks/forms/resources/forms-calendar-styling.xsl
>
>I added:
><xsl:if test="not(fi:styling[@disabled='disabled'] or
>fi:styling[@readonly='readonly'] or fi:styling[@type='hidden'])">
>around the calendar HTML anchor.
>
>The modified code segment in that file now reads:
>    <!-- calendar popup -->
>    <xsl:if test="not(fi:styling[@disabled='disabled'] or
>fi:styling[@readonly='readonly'] or fi:styling[@type='hidden'])">
>    <a href="#" name="{$id}" id="{$id}"
>       onClick="forms_calendar.select(forms_getForm(this)['{@id}'],'{$id}','
>{$format}'); return false;">
>      <img src="{$resources-uri}/cal.gif" border="0" alt="Calendar"/>
>    </a>
>    </xsl:if>
>
>All that I added was the surrounding <xsl:if> block. It works great!!
>
>Should I move this to a separate CONTRIBUTION thread or is this simple
>enough that you would just get it into the cvs archive??
>  
>

Sorry, but there's no "readonly" attribute on fi:styling (you should use 
the "disabled" state instead) and type="hidden" is handled globally for 
the whole field and not only for the calendar image.

But I'm wondering if you're looking at the right source when you say 
"cvs archive". Cocoon has moved from CVS to Subversion for a while now 
and you may have looked at an old version of the XSLs.

Sylvain

-- 
Sylvain Wallez                                  Anyware Technologies
http://www.apache.org/~sylvain           http://www.anyware-tech.com
{ XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }


Mime
View raw message