cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sylvain Wallez <sylv...@apache.org>
Subject Re: CONTRIBUTION: repeater-widget (insert row): InsertRowsActionDefinition
Date Thu, 03 Feb 2005 10:01:22 GMT
depub2 wrote:

>Hello Folks,
>
>I would like to make a small contribution to the cocoon repeater-widget
>(insert row) and would like someone (Sylvain Wallez?) to accept my code; so
>I'll be a "ghostwriter" as it does not make sense for me to maintain this
>small piece of code.
>
>Specifically, I would like to add something like:
>  package org.apache.cocoon.forms.formmodel;
>  public class InsertRowsActionDefinition extends RepeaterActionDefinition
>{}
>
>It will act like DeleteRowsActionDefinition; but instead will insert a
>single row in front of each of the selected rows. This sure seems like a
>natural need for the repeater! Yes?!?
>  
>

Sorry, it doesn't seem natural to me, and I never saw such behaviour, 
particularily inserting several rows at once and inserting them before 
the selected row.

Now I understand that the set of available repeater-actions is currently 
limited, and that "add-row" that inserts a new row at the end of the 
repeater may not be the most convenient when you want to insert a row at 
an arbitrary place in the repeater (although you have the "add-after" 
row-action).

So IMO the behaviour of an "add-rows" action should be to add rows 
_after_ the selected rows. This kind of interaction usually involves a 
single selection, but we could find it acceptable that it is generalized 
to inserting a row after all selected rows.

What do people think?

Sylvain

-- 
Sylvain Wallez                                  Anyware Technologies
http://www.apache.org/~sylvain           http://www.anyware-tech.com
{ XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }


Mime
View raw message