Return-Path: 
 <dev-return-70214-apmail-cocoon-dev-archive=cocoon.apache.org@cocoon.apache.org>
Delivered-To: apmail-cocoon-dev-archive@www.apache.org
Received: (qmail 79739 invoked from network); 12 Jan 2005 11:59:44 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur-2.apache.org with SMTP; 12 Jan 2005 11:59:44 -0000
Received: (qmail 11907 invoked by uid 500); 12 Jan 2005 11:59:41 -0000
Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org
Received: (qmail 11823 invoked by uid 500); 12 Jan 2005 11:59:41 -0000
Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@cocoon.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@cocoon.apache.org>
list-post: <mailto:dev@cocoon.apache.org>
Reply-To: dev@cocoon.apache.org
Delivered-To: mailing list dev@cocoon.apache.org
Received: (qmail 11807 invoked by uid 99); 12 Jan 2005 11:59:41 -0000
X-ASF-Spam-Status: No, hits=-10.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from minotaur.apache.org (HELO minotaur.apache.org)
 (209.237.227.194)
  by apache.org (qpsmtpd/0.28) with SMTP; Wed, 12 Jan 2005 03:59:40 -0800
Received: (qmail 79673 invoked from network); 12 Jan 2005 11:59:39 -0000
Received: from localhost.hyperreal.org (HELO ?127.0.0.1?) (127.0.0.1)
  by localhost.hyperreal.org with SMTP; 12 Jan 2005 11:59:39 -0000
Message-ID: <41E511A7.9020006@apache.org>
Date: Wed, 12 Jan 2005 13:01:43 +0100
From: Carsten Ziegeler <cziegeler@apache.org>
User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: dev@cocoon.apache.org
Subject: Re: ANN: [portal] New CachingPortletAdapter
References: <4C47FFB0CC6A2E4D92550B89B68FC78302F980D8@s2-ba.asset-internal>
In-Reply-To: <4C47FFB0CC6A2E4D92550B89B68FC78302F980D8@s2-ba.asset-internal>
X-Enigmail-Version: 0.89.5.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Rating: localhost.hyperreal.org 1.6.2 0/1000/N
X-Virus-Checked: Checked
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N

DURDINA Michal wrote:
> 
> I checked Pluto 1.0.1-rc1 (and also trunk) and the result is: pluto portal (/portal) does not implement caching yet. The portlet.xml expiration-cache element is parsed in PortletDefinitionImpl but never read (checked with Eclipse -> References). The same is valid for cocoon.
> 
Oh, that's bad and should imho be fixed.

> IMHO it is the responsibility of the portal to implement caching not of portlet container. I think there is nothing to fix in cocoon to enable caching. We have to implement caching in cocoon and pluto portal (/portal subproject) should implement caching its own way. Caching implementation involves no changes in pluto container (/container subproject) that the cocoon is dependent on.
> 
> I suggest I can slightly modify the CachingPortletAdapter to adapt for PortletDefinitionImpl.getExpirationCache() value. Original PortletAdapter can stay untouched and users would have to use new CachingPortletAdapter to enable caching in their portals. I think it is better to provide caching in the new adapter, because users that already used PortletAdapter depend on non-caching behaviour (regardless of <expiration-cache> value in their portlet.xml). WDYT?
> 
Do you mean that the CachingPortletAdapter then implements the caching 
of JSR-168 portlets as outlined in the spec? If so: +1
If not, we shouldn't imho invent our own caching mechanism that differs 
from the spec.

Carsten