Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 75950 invoked from network); 3 Jan 2005 09:58:47 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 3 Jan 2005 09:58:47 -0000 Received: (qmail 57942 invoked by uid 500); 3 Jan 2005 09:58:23 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 57820 invoked by uid 500); 3 Jan 2005 09:58:20 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: dev@cocoon.apache.org Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 57750 invoked by uid 99); 3 Jan 2005 09:58:17 -0000 X-ASF-Spam-Status: No, hits=0.1 required=10.0 tests=FORGED_RCVD_HELO X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Received: from 10.21.96-84.rev.gaoland.net (HELO mail.anyware-tech.com) (84.96.21.10) by apache.org (qpsmtpd/0.28) with ESMTP; Mon, 03 Jan 2005 01:58:14 -0800 Received: from localhost (localhost [127.0.0.1]) by mail.anyware-tech.com (Postfix) with ESMTP id 6004734791 for ; Mon, 3 Jan 2005 10:59:25 +0100 (CET) Received: from mail.anyware-tech.com ([127.0.0.1]) by localhost (trinity [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 14049-06 for ; Mon, 3 Jan 2005 10:59:23 +0100 (CET) Received: from [10.0.0.27] (poukram.anyware [10.0.0.27]) by mail.anyware-tech.com (Postfix) with ESMTP id 72A4C34796 for ; Mon, 3 Jan 2005 10:59:23 +0100 (CET) Message-ID: <41D9172E.60506@anyware-tech.com> Date: Mon, 03 Jan 2005 10:58:06 +0100 From: Sylvain Wallez Organization: Anyware Technologies User-Agent: Mozilla Thunderbird 1.0 (Macintosh/20041206) X-Accept-Language: en-us, en MIME-Version: 1.0 To: dev@cocoon.apache.org Subject: Re: svn commit: r123903 - in cocoon/branches/BRANCH_2_1_X/src: blocks/batik/java/org/apache/cocoon/components/transcoder blocks/batik/java/org/apache/cocoon/components/url blocks/fop/java/org/apache/cocoon/components/renderer blocks/fop/java/org/apache/cocoon/serialization blocks/portal/java/org/apache/cocoon/portal/impl blocks/portal/java/org/apache/cocoon/portal/pluto blocks/scratchpad/java/org/apache/cocoon/generation java/org/apache/cocoon/components/classloader java/org/apache/cocoon/generation java/org/apache/cocoon/xml/dom References: <20050102212700.95858.qmail@minotaur.apache.org> In-Reply-To: <20050102212700.95858.qmail@minotaur.apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at anyware-tech.com X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N antonio@apache.org wrote: >Author: antonio >Date: Sun Jan 2 13:26:59 2005 >New Revision: 123903 > >URL: http://svn.apache.org/viewcvs?view=rev&rev=123903 >Log: >Set static variable as final > > Why should all static variables be final? This is necessary for public constants, but not for internal variables. Although this changes nothing for variables initialized when declared (e.g. "private static Map map = new HashMap()"), it IMO reduces readability when the initialization involves several steps in a static block as below: > /** Batik's original default handler */ >- protected static ParsedURLProtocolHandler defaultHandler; >+ protected final static ParsedURLProtocolHandler defaultHandler = ParsedURL.getHandler(null); // Keep the default handler, if any > > /** > * Change the default handler used by Batik to resolve URLs to a handler >@@ -56,9 +56,6 @@ > * @param logger the logger for logging. > */ > static { >- // Keep the default handler, if any >- SourceProtocolHandler.defaultHandler = ParsedURL.getHandler(null); >- > // Set the default handler to our handler > ParsedURL.registerHandler(new SourceProtocolHandler(null)); > > Sylvain -- Sylvain Wallez Anyware Technologies http://www.apache.org/~sylvain http://www.anyware-tech.com { XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }