cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vadim Gritsenko <va...@reverycodes.com>
Subject Re: svn commit: r125954 - /cocoon/branches/BRANCH_2_1_X/src/blocks/databases/java/org/apache/cocoon/components/language/markup/xsp/EsqlHelper.java
Date Mon, 24 Jan 2005 15:30:32 GMT
antonio@apache.org wrote:
> --- cocoon/branches/BRANCH_2_1_X/src/blocks/databases/java/org/apache/cocoon/components/language/markup/xsp/EsqlHelper.java
(original)
> +++ cocoon/branches/BRANCH_2_1_X/src/blocks/databases/java/org/apache/cocoon/components/language/markup/xsp/EsqlHelper.java
Fri Jan 21 11:24:22 2005
> @@ -73,9 +69,7 @@
>                  buffer = new byte[length];
>                  reader.read(buffer);
>                  reader.close();
> -                if (buffer == null)
> -                    return null;
> -                return buffer;
> +                return buffer != null ? buffer : null;

You can just return buffer here:

> +                return buffer;

:)

PS Do you think it's time to merge your changes to 2.2? It makes harder to keep 
branches in sync when they are already not...

Vadim

Mime
View raw message