cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ralph Goers <Ralph.Go...@dslextreme.com>
Subject Re: svn commit: r125646 - /cocoon/trunk/src/blocks/cron/java/org/apache/cocoon/components/cron/QuartzJobScheduler.java
Date Thu, 20 Jan 2005 00:13:25 GMT
Vadim Gritsenko wrote:

> rgoers@apache.org wrote:
>
>> Author: rgoers
>> Date: Wed Jan 19 11:58:55 2005
>> New Revision: 125646
>>
>> URL: http://svn.apache.org/viewcvs?view=rev&rev=125646
>> Log:
>> executor attribute was never being set. Fix NPE.
>>
>> Modified:
>>    
>> cocoon/trunk/src/blocks/cron/java/org/apache/cocoon/components/cron/QuartzJobScheduler.java

>>
>>
>> Modified: 
>> cocoon/trunk/src/blocks/cron/java/org/apache/cocoon/components/cron/QuartzJobScheduler.java

>>
>> Url: 
>> http://svn.apache.org/viewcvs/cocoon/trunk/src/blocks/cron/java/org/apache/cocoon/components/cron/QuartzJobScheduler.java?view=diff&rev=125646&p1=cocoon/trunk/src/blocks/cron/java/org/apache/cocoon/components/cron/QuartzJobScheduler.java&r1=125645&p2=cocoon/trunk/src/blocks/cron/java/org/apache/cocoon/components/cron/QuartzJobScheduler.java&r2=125646

>>
>> ============================================================================== 
>>
>> --- 
>> cocoon/trunk/src/blocks/cron/java/org/apache/cocoon/components/cron/QuartzJobScheduler.java
   
>> (original)
>> +++ 
>> cocoon/trunk/src/blocks/cron/java/org/apache/cocoon/components/cron/QuartzJobScheduler.java
   
>> Wed Jan 19 11:58:55 2005
>> @@ -572,7 +572,8 @@
>>          jobDataMap.put(DATA_MAP_LOGGER, getLogger());
>>          jobDataMap.put(DATA_MAP_CONTEXT, this.context);
>>          jobDataMap.put(DATA_MAP_MANAGER, this.manager);
>> -        jobDataMap.put(DATA_MAP_RUN_CONCURRENT, concurent? 
>> Boolean.TRUE: Boolean.FALSE);
>> +        jobDataMap.put(DATA_MAP_RUN_CONCURRENT,
>> +            concurent? Boolean.TRUE.booleanValue(): 
>> Boolean.FALSE.booleanValue());
>
>
> Won't it fail later on here?
> final Boolean canRunConcurrentlyB = ((Boolean) 
> data.get(QuartzJobScheduler.DATA_MAP_RUN_CONCURRENT));
>
>
> Vadim 

No.  There are multiple versions of the put method. The one that takes 
boolean actually creates a Boolean and stores it.  I changed it because 
IntelliJ was complaining that it couldn't figure out whether to use 
put(Object, Object) or put(String, boolean).  Presumably this shows up 
as a warning somewhere during compilation.

Ralph


Mime
View raw message