cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 33097] - caching of i18n XMLResourceBundle's is faulty with multiple locations
Date Tue, 18 Jan 2005 20:46:08 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=33097>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33097


joerg.heinicke@gmx.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dev@cocoon.apache.org
         AssignedTo|dev@cocoon.apache.org       |joerg.heinicke@gmx.de




------- Additional Comments From joerg.heinicke@gmx.de  2005-01-18 21:46 -------
Okay, the patch is not perfect as it does to many changes at once (using store,
fixing synchronization (?), fixing cache key). At the weekend or next week I can
probably provide better patch if nobody wants to jump in now.

For the caching: Until now for each location one bundle is created, but the
bundles are put into hierarchy with the last in the i18n transformer component
declaration as highest parent, which will on pipeline usage ask as last for the
key, if it has not been found before - what a sentence ...

But the hierarchy is built from the end: last location => bundle => cache;
pre-last location => bundle with last location as parent bundle => cache;
pre-pre-last (or first in my case) location => bundle with pre-last location as
parent bundle => cache.

So each location is already cached individually, but with the parent bundle
attached. The implementation was wrong, when it took only the filename of the
current first location, but not the filenames of the attached parent bundles as
cache key, because one location first used it could not be reused as you will
get the old one back. My change builds the cache key not only of the location of
the current bundle, but takes also the attached parent bundles into account.

Joerg

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are on the CC list for the bug, or are watching someone who is.

Mime
View raw message