Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 66440 invoked from network); 31 Dec 2004 17:13:49 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 31 Dec 2004 17:13:49 -0000 Received: (qmail 77824 invoked by uid 500); 31 Dec 2004 17:13:43 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 77775 invoked by uid 500); 31 Dec 2004 17:13:43 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: dev@cocoon.apache.org Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 77762 invoked by uid 99); 31 Dec 2004 17:13:43 -0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: domain of joerg.heinicke@gmx.de designates 213.165.64.20 as permitted sender) Received: from pop.gmx.net (HELO mail.gmx.net) (213.165.64.20) by apache.org (qpsmtpd/0.28) with SMTP; Fri, 31 Dec 2004 09:13:39 -0800 Received: (qmail invoked by alias); 31 Dec 2004 17:13:36 -0000 Received: from p50880761.dip0.t-ipconnect.de (EHLO [192.168.122.254]) (80.136.7.97) by mail.gmx.net (mp001) with SMTP; 31 Dec 2004 18:13:36 +0100 X-Authenticated: #3483660 Message-ID: <41D58936.7030906@gmx.de> Date: Fri, 31 Dec 2004 18:15:34 +0100 From: Joerg Heinicke User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041217 X-Accept-Language: de-de, de, en-us, en-gb, en MIME-Version: 1.0 To: dev@cocoon.apache.org Subject: Re: svn commit: r123799 - /cocoon/branches/BRANCH_2_1_X/src/blocks/repository/java/org/apache/cocoon/components/repository/SourceRepositoryImpl.java References: <20041231151259.90977.qmail@minotaur.apache.org> In-Reply-To: <20041231151259.90977.qmail@minotaur.apache.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N On 31.12.2004 16:12, antonio@apache.org wrote: > Author: antonio > Date: Fri Dec 31 07:12:59 2004 > New Revision: 123799 > > URL: http://svn.apache.org/viewcvs?view=rev&rev=123799 > Log: > Remove unused code > Modified: > cocoon/branches/BRANCH_2_1_X/src/blocks/repository/java/org/apache/cocoon/components/repository/SourceRepositoryImpl.java > > Modified: cocoon/branches/BRANCH_2_1_X/src/blocks/repository/java/org/apache/cocoon/components/repository/SourceRepositoryImpl.java > Url: http://svn.apache.org/viewcvs/cocoon/branches/BRANCH_2_1_X/src/blocks/repository/java/org/apache/cocoon/components/repository/SourceRepositoryImpl.java?view=diff&rev=123799&p1=cocoon/branches/BRANCH_2_1_X/src/blocks/repository/java/org/apache/cocoon/components/repository/SourceRepositoryImpl.java&r1=123798&p2=cocoon/branches/BRANCH_2_1_X/src/blocks/repository/java/org/apache/cocoon/components/repository/SourceRepositoryImpl.java&r2=123799 > ============================================================================== > --- cocoon/branches/BRANCH_2_1_X/src/blocks/repository/java/org/apache/cocoon/components/repository/SourceRepositoryImpl.java (original) > +++ cocoon/branches/BRANCH_2_1_X/src/blocks/repository/java/org/apache/cocoon/components/repository/SourceRepositoryImpl.java Fri Dec 31 07:12:59 2004 > @@ -226,17 +226,9 @@ > int status = STATUS_OK; > final Iterator iter = ((TraversableSource) source).getChildren().iterator(); > while (iter.hasNext()) { > - Source child = null; > - try { > - status = remove((Source) iter.next()); > - if (status != STATUS_OK) { > - return status; > - } > - } > - finally { > - if (child != null) { > - m_resolver.release(child); ------------------------------^^^^^^^^^^^^^^^^^^^^^^^^^^ > - } > + status = remove((Source) iter.next()); > + if (status != STATUS_OK) { > + return status; > } > } > } What about releasing the Source's?? Joerg