Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Received-SPF: pass (hermes.apache.org: local policy)
Message-ID: <41B9B9AE.3010008@mobilebox.pl>
Date: Fri, 10 Dec 2004 15:58:54 +0100
From: Leszek Gawron <lgawron@mobilebox.pl>
User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206)
MIME-Version: 1.0
To: dev@cocoon.apache.org
Subject: Re: Possible security problem with flowscript
References: <A955EA1F8FE31749AEC8C998082F6C7C129878@hai01.hippo.local>
In-Reply-To: <A955EA1F8FE31749AEC8C998082F6C7C129878@hai01.hippo.local>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Johan Stuyts wrote:
> Hi,
> 
> Sorry about reacting to this thread after one month of inactivity, but we recently switched to a Cocoon version which includes this fix. I have tried refactoring our application, but it was more work than I expected.
> 
> Having an option to turn this behaviour on or off would really make things easier for me. Our application can run as it is and from the warnings in the log I can determine what should be changed. Using these warnings I can gradually make our application compliant with sitemap-bound continuations.
> 
> I propose to change the current code in ContinuationsManagerImpl to this code. As you can see the warnings will always be added to the log as an incentive to make changes to code which still uses shared continuations:
>     public WebContinuation lookupWebContinuation(String id, String interpreterId) {
>         WebContinuation kont = (WebContinuation) idToWebCont.get(id);
>         if ( kont != null ) {
>             boolean interpreterMatches = kont.interpreterMatches(interpreterId);
>             if (!interpreterMatches && getLogger().isWarnEnabled()) {
>                 getLogger().warn("WK: Continuation (" + kont.getId() 
>                                  + ") lookup for wrong interpreter. Bound to: " 
>                                  + kont.getInterpreterId() + ", looked up for: " 
>                                  + interpreterId);
>             }
> 
>>>>>       return interpreterMatches || allowBackwardCompatibleContinuationSharing ? kont : null;
> 
>         }
>         return null;
>     }
> 
> 'allowBackwardCompatibleContinuationSharing' will be a configuration option which defaults to 'false'.
> 
> If nobody objects I will make the changes, create patches and add a new bug for this.
> 
> Johan Stuyts

Johan,
Please describe your usecase when you were resuming continuations in 
different sitemap. What did you try to achieve by this?

-- 
Leszek Gawron                                      lgawron@mobilebox.pl
Project Manager                                    MobileBox sp. z o.o.
+48 (61) 855 06 67                              http://www.mobilebox.pl
mobile: +48 (501) 720 812                       fax: +48 (61) 853 29 65