Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 827 invoked from network); 1 Nov 2004 21:15:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 1 Nov 2004 21:15:24 -0000 Received: (qmail 34037 invoked by uid 500); 1 Nov 2004 21:15:20 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 33856 invoked by uid 500); 1 Nov 2004 21:15:19 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: dev@cocoon.apache.org Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 33827 invoked by uid 99); 1 Nov 2004 21:15:19 -0000 X-ASF-Spam-Status: No, hits=0.1 required=10.0 tests=NO_REAL_NAME,UPPERCASE_25_50 X-Spam-Check-By: apache.org Received: from [192.18.33.10] (HELO exchange.sun.com) (192.18.33.10) by apache.org (qpsmtpd/0.28) with SMTP; Mon, 01 Nov 2004 13:15:18 -0800 Received: (qmail 4204 invoked by uid 50); 1 Nov 2004 21:15:17 -0000 Date: 1 Nov 2004 21:15:17 -0000 Message-ID: <20041101211517.4203.qmail@nagoya.betaversion.org> From: bugzilla@apache.org To: dev@cocoon.apache.org Cc: Subject: DO NOT REPLY [Bug 30417] - [PATCH] ImageReader needs "uniform scale-to-fit" option X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=30417 [PATCH] ImageReader needs "uniform scale-to-fit" option ------- Additional Comments From ml@wrinkledog.com 2004-11-01 21:15 ------- Oh yeah... the bug was that in the original patch was fitUniform didn't do something reasonable if the width or height parameter was missing or zero. The thought was that if you're bothering to specify scaling to fit, you're supplying both dimensions — but that's not necessarily true, the invoker might not know whether either of the dimensions is zero. Also, getKey() didn't incorporate the values of fitUniform or enlarge.