cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Heinicke <joerg.heini...@gmx.de>
Subject Re: svn commit: r106302 - /cocoon/branches/BRANCH_2_1_X/src/blocks/batik/java/org/apache/cocoon/transformation/FragmentExtractorTransformer.java
Date Wed, 24 Nov 2004 12:21:39 GMT
On 24.11.2004 01:24, Vadim Gritsenko wrote:

>>> IMHO, adding single line would be simplier:
>>>
>>>            if (uri == null) uri = "";
>>>
>>> And it can not be null anyway, so logging a warning is an option.
>>>
>>>> -        if ((uri == null || this.extractURI.equals(uri)) && 
>>>> this.extractElement.equals(loc)) {
>>>> +        if (((uri == null && this.extractURI.equals("")) || 
>>>> this.extractURI.equals(uri)) && this.extractElement.equals(loc))
{
>>
>>
>>
>> I had this in mind too, but should a transformer fix the behaviour of 
>> another component? In theory you can add this fix to every transformer 
>> or serializer.
> 
> 
> Well, if you decide not to fix - than we should rollback the change! Not 
> that I'm against it, though :)

That would be consequent then :-) Ok, I will fix it tomorrow by the one 
liner.

Joerg

Mime
View raw message