cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vadim Gritsenko <va...@reverycodes.com>
Subject Re: svn commit: r106302 - /cocoon/branches/BRANCH_2_1_X/src/blocks/batik/java/org/apache/cocoon/transformation/FragmentExtractorTransformer.java
Date Wed, 24 Nov 2004 00:24:45 GMT
Joerg Heinicke wrote:
> On 23.11.2004 17:14, Vadim Gritsenko wrote:
> 
>> IMHO, adding single line would be simplier:
>>
>>            if (uri == null) uri = "";
>>
>> And it can not be null anyway, so logging a warning is an option.
>>
>>> -        if ((uri == null || this.extractURI.equals(uri)) && 
>>> this.extractElement.equals(loc)) {
>>> +        if (((uri == null && this.extractURI.equals("")) || 
>>> this.extractURI.equals(uri)) && this.extractElement.equals(loc)) {
> 
> 
> I had this in mind too, but should a transformer fix the behaviour of 
> another component? In theory you can add this fix to every transformer 
> or serializer.

Well, if you decide not to fix - than we should rollback the change! Not that 
I'm against it, though :)

Vadim

Mime
View raw message