cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 32157] - [PATCH] redirect to relative urls does not work correctly in Websphere 5.1
Date Mon, 29 Nov 2004 10:42:17 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=32157>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32157


durdina@asset.sk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WORKSFORME




------- Additional Comments From durdina@asset.sk  2004-11-29 11:42 -------
Yes, you are right.
Pluto issues a redirect in PortletContainerImpl and this redirect is processed 
differently in 2_2_x and 2_1_x. In 2_1_x (target of this patch) cocoon portal 
called servlet container sendRedirect. In branch 2_2_x it is pluto that calls 
servlet container sendRedirect.

Methods processPortletAction() and redirect() in:
http://svn.apache.org/repos/asf/portals/pluto/tags/release-1.0.1-
rc1/container/src/java/org/apache/pluto/PortletContainerImpl.java 
 - that's the part where Pluto container issues a redirect after portlet action.

Branch 2_1_x:
HttpServletResponse sent to processAction is 
http://svn.apache.org/repos/asf/cocoon/branches/BRANCH_2_1_X/src/blocks/portal/j
ava/org/apache/cocoon/portal/pluto/servlet/ServletResponseImpl.java
 - does not implement HttpServletResponseWrapper (servlet-api 2.3)
 - redirect redirect url is saved to ServletResponseImpl.redirectURL
 - this field is subsequently read in 
http://svn.apache.org/repos/asf/cocoon/branches/BRANCH_2_1_X/src/blocks/portal/j
ava/org/apache/cocoon/portal/impl/PortletPortalManager.java
 - redirect is actual called few lines after in PortletPortalManager

Branch 2_2_x:
HttpServletResponse sent to processAction is 
http://svn.apache.org/repos/asf/cocoon/trunk/src/blocks/portal/java/org/apache/c
ocoon/portal/pluto/servlet/ServletResponseImpl.java
 - DOES implement HttpServletResponseWrapper (servlet api 2.3)
 - sendRedirect is no longer called on ServletResponseImpl because it is 
wrapper and pluto retrieves actual wrapped request to call the redirect on

In my opinion:
 - this patch cannot be applied to 2_2_x (trunk)
 - it can be applied to 2_1_x but it has no sense since in 2_2_x the "Webpshere 
bug" will be present again
 - new solution for absolutizing redirect urls needs to be found to shadow 
differences between Tomcat and Websphere or JRun in relative redirects 
processing. That means that cocoon should optionally change all relative 
redirects to absolute ones BEFORE the servlet container sendRedirect() is called

WDYT? I changed the status of this issue to WORKSFORMORE.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

Mime
View raw message