cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vadim Gritsenko <va...@reverycodes.com>
Subject Re: svn commit: rev 56145 - cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/components
Date Sun, 31 Oct 2004 18:50:26 GMT
cziegeler@apache.org wrote:
> Author: cziegeler
> Date: Sun Oct 31 10:32:28 2004
> New Revision: 56145
> 
> Modified:
>    cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/components/CocoonComponentManager.java
> Log:
> Revert commit 55286 which causes NPEs and other exceptions with the cocoon protocol -
don't know why though
...
> @@ -591,8 +594,8 @@
>       * All RequestLifecycleComponents and autoreleaseComponents are
>       * released.
>       */
> -    synchronized void release() {
> -        if (this.requestLifecycleComponents != null) {
> +    void release() {
> +        if ( this.requestLifecycleComponents != null ) {
>              final Iterator iter = this.requestLifecycleComponents.values().iterator();
>              while (iter.hasNext()) {
>                  final Object[] o = (Object[])iter.next();

But what about synchronization? Without it, it fails with 
IndexOutOfBoundsExceptions or some such.

Vadim

Mime
View raw message