cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 31649] - [Patch] Flowscript: Switch to re-implementation of official Rhino
Date Fri, 15 Oct 2004 19:00:53 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=31649>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31649

[Patch] Flowscript: Switch to re-implementation of official Rhino





------- Additional Comments From igor@fastmail.fm  2004-10-15 19:00 -------
Reinhard Poetz wrote:

> So far, I found two problems:
> 
> 1.) samples/blocks/forms/form1.flow
> seems to be a problem with type recognition

This is a bug in Rhino bindings in Cocoon and caused by the following code in
ScriptableWidget.put:

...
    value = unwrap(value);
    if (value instanceof Double) {
	// make woody accept a JS Number

The problem here is that the code assumes that numbers in Rhino are represented
by Double. But this is wrong and was wrong from the first public release of
Rhino in 1998 as to check for numbers java applications should always check for
Number, not Double. 

Since it is possible to modify the the JavaScript source in the example so the
number would be Integer even with Chris' version of Rhino that has to be fixed
in any case in all instances of this duplicated code in Cocoon.

> 
> 2.) samples/blocks/forms/carselector
> Seems to be a problem of event handling in Cocoon Forms which uses Rhino (but
> creating continuations is not allowed in form events)

I fixed that compatibility issue in Rhino CVS and that should work now.

Mime
View raw message