cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hunsberger, Peter" <Peter.Hunsber...@STJUDE.ORG>
Subject RE: [RT] applying SoC on cocoon itself
Date Wed, 20 Oct 2004 21:21:47 GMT
Stefano Mazzocchi <stefano@apache.org> writes:
> 
> Unico Hommes wrote:
> 
> > I've often thought that the signature of the setup() method 
> was wrong.
> > The src parameter is passed as a String, the component is free to 
> > interpret it as anything it wishes. But I think this parameter was 
> > really only meant to ever be interpreted as a Source 
> object. So instead 
> > of setup(SourceResolver resolver, Map om, String src, 
> Parameters pars) 
> > the method should be setup(Source source, Map om, 
> Parameters pars). That 
> > also unambiguously defines the meaning of the src attribute.
> 
> Amen. Too bad this is the most back-incompatible change you can think 
> of. :-(

The old style method could hang around but be deprecated? Having a new
interface with the old one deprecated (and in the deprecated block)
would make it even more obvious, but who wants to change interface
names?



Mime
View raw message