Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Received-SPF: pass (hermes.apache.org: local policy)
Mime-Version: 1.0 (Apple Message framework v619)
In-Reply-To: <415858A4.3030900@reverycodes.com>
References: <20040927175711.34530.qmail@minotaur.apache.org>
 <22B80CAE-10AF-11D9-B23F-000A95984AEA@betaversion.org>
 <415858A4.3030900@reverycodes.com>
Content-Type: multipart/signed; micalg=sha1; boundary=Apple-Mail-4--107553877;
 protocol="application/pkcs7-signature"
Message-Id: <9BBCCD0C-10B6-11D9-B23F-000A95984AEA@betaversion.org>
From: Pier Fumagalli <pier@betaversion.org>
Subject: FIXME in IncludeTransformer [Was: Re: Adding Files to Subversion]
Date: Mon, 27 Sep 2004 19:54:06 +0100
To: dev@cocoon.apache.org


--Apple-Mail-4--107553877
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=US-ASCII;
	format=flowed

On 27 Sep 2004, at 19:15, Vadim Gritsenko wrote:
> Pier Fumagalli wrote:On 27 Sep 2004, at 18:57, pier@apache.org wrote:
>>> Author: pier
>>> Date: Mon Sep 27 10:57:10 2004
>>> New Revision: 47320
>>>
>>> Modified:
>>>     
>>> cocoon/branches/BRANCH_2_1_X/src/blocks/scratchpad/java/org/apache/ 
>>> cocoon/transformation/IncludeTransformer.java
>>> Log:
>>> More JavaDOCs, comments, re-indenting, and filtering out the 
>>> "include"  namespaces declarations
>> I think there's a line-ending problem with this file. My local diffs  
>> were much smaller!
>>     Pier (scratching his head, and wondering)
>
> Don' wonder; properties were missing.

Cheeridos!

Now, an annotated dump on the source tells me that you added the 
following FIXME comment:

36336      unico     public Serializable getKey() {
  47017 vgritsenko         // FIXME: In case of including "cocoon://" or 
other dynamic sources
  47017 vgritsenko         // key has to be dynamic.
  47017 vgritsenko         return "I";
  36336      unico     }

Care to explain the problem? I need to have this working (somehow) and 
have some time on my hands to spare and dedicate to the cause of 
caching! :-P

	Pier

--Apple-Mail-4--107553877
Content-Transfer-Encoding: base64
Content-Type: application/pkcs7-signature;
	name=smime.p7s
Content-Disposition: attachment;
	filename=smime.p7s

MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIGHDCCAtUw
ggI+oAMCAQICAwttIjANBgkqhkiG9w0BAQQFADBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhh
d3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVt
YWlsIElzc3VpbmcgQ0EwHhcNMDQwMTA3MDE0MjIwWhcNMDUwMTA2MDE0MjIwWjBGMR8wHQYDVQQD
ExZUaGF3dGUgRnJlZW1haWwgTWVtYmVyMSMwIQYJKoZIhvcNAQkBFhRwaWVyQGJldGF2ZXJzaW9u
Lm9yZzCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAMC/E+M4UqeEBnSTj0AIMX9oMWSo
9Te7VUPPvINPSKKLEElGaottQeJaYRSlfGIjUyXkzTlbw0MFAPaqfU97t+5xeNkighKu7ZcVIPfz
AARv5+wp+gON5uSNV2GzP0rPwAbUDIG2zaSonJlN7whVG5fO9G1u0oYaWolpgKUAc3T5P5Gv737L
G1iSxrnl9DQlVDIuZWrcgWYX/MFFlf7prXXm6lS08lYhGi0NrIf5SploZzMG+uHHzVDgV8WCTQr1
hXB825VLhnWw4GPFx5qLVgElctVz88S/+t8O/+1kRf3ky8SsewfyCTuDAk4XHzfb7M5bECiZ1yni
dhW+sD1y/TsCAwEAAaMxMC8wHwYDVR0RBBgwFoEUcGllckBiZXRhdmVyc2lvbi5vcmcwDAYDVR0T
AQH/BAIwADANBgkqhkiG9w0BAQQFAAOBgQAjeSEnk3U1P46rHiBGJP7StkQg/DVkw4ModEYCEwxm
8QYxQPGMciXn2goZ5ahK6Uu8Rfa+ZPSxV96VFsOlc3oFF02VYsrRy+xJukuSMY0z/0UvHnTZmVfm
CJpxMoVMYQO3fC2XdmCNASu8FbvOgaS71fQf3b0wgebLeLROR7u5XjCCAz8wggKooAMCAQICAQ0w
DQYJKoZIhvcNAQEFBQAwgdExCzAJBgNVBAYTAlpBMRUwEwYDVQQIEwxXZXN0ZXJuIENhcGUxEjAQ
BgNVBAcTCUNhcGUgVG93bjEaMBgGA1UEChMRVGhhd3RlIENvbnN1bHRpbmcxKDAmBgNVBAsTH0Nl
cnRpZmljYXRpb24gU2VydmljZXMgRGl2aXNpb24xJDAiBgNVBAMTG1RoYXd0ZSBQZXJzb25hbCBG
cmVlbWFpbCBDQTErMCkGCSqGSIb3DQEJARYccGVyc29uYWwtZnJlZW1haWxAdGhhd3RlLmNvbTAe
Fw0wMzA3MTcwMDAwMDBaFw0xMzA3MTYyMzU5NTlaMGIxCzAJBgNVBAYTAlpBMSUwIwYDVQQKExxU
aGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUgUGVyc29uYWwgRnJl
ZW1haWwgSXNzdWluZyBDQTCBnzANBgkqhkiG9w0BAQEFAAOBjQAwgYkCgYEAxKY8VXNV+065ypla
HmjAdQRwnd/p/6Me7L3N9VvyGna9fww6YfK/Uc4B1OVQCjDXAmNaLIkVcI7dyfArhVqqP3FWy688
Cwfn8R+RNiQqE88r1fOCdz0Dviv+uxg+B79AgAJk16emu59l0cUqVIUPSAR/p7bRPGEEQB5kGXJg
t/sCAwEAAaOBlDCBkTASBgNVHRMBAf8ECDAGAQH/AgEAMEMGA1UdHwQ8MDowOKA2oDSGMmh0dHA6
Ly9jcmwudGhhd3RlLmNvbS9UaGF3dGVQZXJzb25hbEZyZWVtYWlsQ0EuY3JsMAsGA1UdDwQEAwIB
BjApBgNVHREEIjAgpB4wHDEaMBgGA1UEAxMRUHJpdmF0ZUxhYmVsMi0xMzgwDQYJKoZIhvcNAQEF
BQADgYEASIzRUIPqCy7MDaNmrGcPf6+svsIXoUOWlJ1/TCG4+DYfqi2fNi/A9BxQIJNwPP2t4WFi
w9k6GX6EsZkbAMUaC4J0niVQlGLH2ydxVyWN3amcOY6MIE9lX5Xa9/eH1sYITq726jTlEBpbNU13
41YheILcIRk13iSx0x1G/11fZU8xggLnMIIC4wIBATBpMGIxCzAJBgNVBAYTAlpBMSUwIwYDVQQK
ExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUgUGVyc29uYWwg
RnJlZW1haWwgSXNzdWluZyBDQQIDC20iMAkGBSsOAwIaBQCgggFTMBgGCSqGSIb3DQEJAzELBgkq
hkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTA0MDkyNzE4NTQwN1owIwYJKoZIhvcNAQkEMRYEFIRE
EdGVGkvvurq1MxVFmiPlqqg4MHgGCSsGAQQBgjcQBDFrMGkwYjELMAkGA1UEBhMCWkExJTAjBgNV
BAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25h
bCBGcmVlbWFpbCBJc3N1aW5nIENBAgMLbSIwegYLKoZIhvcNAQkQAgsxa6BpMGIxCzAJBgNVBAYT
AlpBMSUwIwYDVQQKExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3
dGUgUGVyc29uYWwgRnJlZW1haWwgSXNzdWluZyBDQQIDC20iMA0GCSqGSIb3DQEBAQUABIIBAEbl
ICbqPQH/N2Y5vdLyrjbl/LsDtn4T/RFVE76GqcH5PgC2fBPhEuvorL1r/Ohclqe2aZ2Ut2FAPsjC
bamMjqfgynxCmU/NL/H00MjnE68FRkwd3o07mDMDVEzIUXzEvA9rYHw+ELAcPs6lRKIziXup34UA
AcrP6fYjA9TVEBld4NGx7Z2ROoFGlTksOhDLZkQazCYhMw1sczXa4wV3lFZPz9o7pmIqjMlWeInF
0wDR/fpEAv1cH+V172KJrj3OBkpD7ncnRL7QL8saOGzmFqJuWJwcoI8AtHF4ow4WR2ogtduVn4hm
KHG29p3jW3v5/KSIlkJfjL0VXW+iut9VsBsAAAAAAAA=

--Apple-Mail-4--107553877--